Repository navigation
fix(engine): raise the recursion limit so release builds compile - #2294
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The v0.90.0 tag build failed on all four targets with
error: queries overflow the depth limit!while compilingrustcode-tui. The ACP router chains one handler per request type into one nested future type. Adding_rustcode/rewind(#2291) pushed its layout past the default query depth, but only in release builds. PR CI builds debug, so the PRs passed.This sets
#![recursion_limit = "256"]on the TUI binary (rustcode), where the layout is computed, and on the engine crate, with a comment explaining why.The v0.90.0 tag stays as it is, without a published release; v0.90.1 follows this fix.
Changelog
none
Testing
cargo build --locked --release -p rustcode-tui, the build workflow's command, fails on main and passes here.cargo fmt --all -- --check,cargo check --workspace --tests,cargo test --workspace.https://claude.ai/code/session_01WYtCe3728gaXHYngudswkC