feat: add JobPosting named schema to extract tool (#146)#192
Open
josephkehan-prog wants to merge 1 commit into
Open
feat: add JobPosting named schema to extract tool (#146)#192josephkehan-prog wants to merge 1 commit into
josephkehan-prog wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds a ChangesJobPosting schema
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant ExtractTool
participant extractNamedSchema
participant extractJobPosting
participant JSONLD
participant HTMLDOM
ExtractTool->>extractNamedSchema: request JobPosting schema
extractNamedSchema->>extractJobPosting: pass HTML and URL
extractJobPosting->>JSONLD: inspect JobPosting blocks
JSONLD-->>extractJobPosting: structured fields or no match
extractJobPosting->>HTMLDOM: read h1 and job:* metadata on fallback
HTMLDOM-->>extractJobPosting: normalized fields
extractJobPosting-->>extractNamedSchema: JobPostingData or null
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
josephkehan-prog
added a commit
to josephkehan-prog/wigolo
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
Adds
JobPostingto the extract tool's named schemas (JSON-LD first, meta/DOM fallback), copied from theEventListing.tspattern.schemas/index.ts(NAMED_SCHEMAS + union + switch),types.ts(NamedSchemaType),server/tool-schemas.ts(extract tool enum)classifier.ts, but that file is the content-type classifier and does not register named schemas — the registration points above are the real ones (found by grepping EventListing across src/)EventListing.test.ts; registry test updated 6→7Test plan
npx vitest run tests/unit/extraction/v1/schemas/JobPosting.test.ts tests/unit/extraction/v1/schemas/index.test.ts— 9/9npx tsc --noEmitcleanSummary by CodeRabbit
New Features
JobPostingas a supported named extraction schema.Bug Fixes
Tests