Skip to content

cppcheck and clang static analyzer warnings that need a look #66

Open
Open
cppcheck and clang static analyzer warnings that need a look#66

Description

@seanm
seanm
opened on Jan 4, 2019

I fixed some cppcheck and clang static analyzer warnings, but others need someone that knows the code:

The enclosing 'for' loop goes to m_NDims (the ivar), should be _nDims (the param)?

src/metaImage.cxx:584:18: Assigned value is garbage or undefined
src/metaImage.cxx:590:25: Assigned value is garbage or undefined

These may be dead code, or something is failing to use those results...

src/metaImage.cxx:1205:5: Value stored to 'posend' is never read
src/metaImage.cxx:2908:9: Value stored to 'fileImageDim' is never read
src/metaImage.cxx:3044:9: Value stored to 'maxV' is never read

redundantAssignment,src/metaImage.cxx:3051,style,Variable 'maxV' is reassigned a value before the old one has been used.
unreadVariable,src/metaImage.cxx:1205,style,Variable 'posend' is assigned a value that is never used.
unreadVariable,src/metaImage.cxx:1290,style,Variable 'elementDataFileName' is assigned a value that is never used.

Activity

  1. dzenanz commented on Jan 10, 2019

    @dzenanz
    dzenanz
    on Jan 10, 2019
    Member

    Is this issue addressed by one of your recent PRs? Perhaps write Closes #66 in the commit message or PR description to reference this issue and have it automatically closed when the PR is merged. You can also reference a merged PR from here and close the issue manually.

  2. seanm commented on Jan 10, 2019

    @seanm
    seanm
    on Jan 10, 2019
    ContributorAuthor

    No, I created this ticket precisely because I don't know how to properly fix them, if I did, I would have just created a PR. :)

    These need someone that knows the code.

  3. seanm commented on Feb 12, 2021

    @seanm
    seanm
    on Feb 12, 2021
    ContributorAuthor

    @dzenanz @hjmjohnson @aylward

    I've just run cppcheck again and fixed a few more things in: #103

    There are a few more that look legit that I daren't fix not knowing this codebase at all:

    derefInvalidIteratorRedundantCheck,src/metaCommand.cxx:819,warning,Either the condition 'it!=m_OptionVector.end()' is redundant or there is possible dereference of an invalid iterator: it.

ignoredReturnValue,src/metaImage.cxx:1059,warning,Return value of function buffer.find() is not used.

unreadVariable,src/metaImage.cxx:1136,style,Variable 'elementDataFileName' is assigned a value that is never used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions