Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Dropdown component should not use deprecated "componentWillUpdate" lifecycle method #55

Description

@broneks

Problem:
componentWillUpdate is deprecated and will eventually be removed following React v17.

See warning message here:
Screen Shot 2019-08-17 at 16 23 30

Suggestion:
It would be wise to switch this method for a componentDidMount being that this block of code is adding event listeners which don't need to be re-added on/before every update.

componentWillUpdate() {

Activity

  1. rajan-gith commented on Dec 4, 2019

    @rajan-gith

    how to fix this warning

  2. frealv commented on Jun 11, 2020

    @frealv

    This is still an issue.

  3. broneks commented on Jul 3, 2020

    @broneks
    Author

    Duplicated by: #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions