Skip to content

Support object and array as params for JsonRPC - #8

Merged
Kas-tle merged 1 commit into
Kas-tle:masterfrom
rtm516:fix/object-params
Jul 13, 2026
Merged

Kas-tle merged 1 commit into
Kas-tle:masterfrom
rtm516:fix/object-params

Conversation

@rtm516

@rtm516 rtm516 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

It looks like at somepoint today Mojang changed the params sent with JsonRPC from array to object, this fixes that while maintaing support for the old array

Error snippet from before the change (grabbed from Discord)

Error processing signaling frame: {"jsonrpc":"2.0","id":25,"method":"Signaling_ReceiveMessage_v1_0","params":{"From":"9121ea2b-f1c9-09ed-9596-7b8799cf0e0b","Message":"{\u0022params\u0022:{\u0022netherNetId\u0022:\u00227950929283017628844\u0022,\u0022message\u0022:\u0022CANDIDATEADD 2853288392834253181 candidate:1907536085 1 udp 41885695 XXX.XXX.XXX.XXX 51743 typ relay raddr YYY.YYY.YYY.YYY rport 50244 generation 0 ufrag Go7\u002B network-id 1 network-cost 50\u0022},\u0022jsonrpc\u0022:\u00222.0\u0022,\u0022method\u0022:\u0022Signaling_WebRtc_v1_0\u0022}","Id":"14a3dd88-a9bc-45b2-b7f6-cbc0e678b09d"}}�[m�[m
java.lang.ClassCastException: class com.google.gson.JsonObject cannot be cast to class com.google.gson.JsonArray (com.google.gson.JsonObject and com.google.gson.JsonArray are in unnamed module of loader 'app')
	at com.google.gson.JsonObject.getAsJsonArray(JsonObject.java:211) ~[MCXboxBroadcastStandalone.jar:?]
	at dev.kastle.netty.channel.nethernet.signaling.NetherNetXboxRpcSignaling.handleRequest(NetherNetXboxRpcSignaling.java:127) ~[MCXboxBroadcastStandalone.jar:?]
	at dev.kastle.netty.channel.nethernet.signaling.NetherNetXboxRpcSignaling.channelRead0(NetherNetXboxRpcSignaling.java:85) [MCXboxBroadcastStandalone.jar:?]
	at dev.kastle.netty.channel.nethernet.signaling.NetherNetXboxRpcSignaling.channelRead0(NetherNetXboxRpcSignaling.java:23) [MCXboxBroadcastStandalone

@Kas-tle
Kas-tle merged commit 2c9e7e5 into Kas-tle:master Jul 13, 2026
@rtm516
rtm516 deleted the fix/object-params branch July 13, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants