Repository navigation
Fix empty typed constructors - #86
Conversation
|
Thank you for reporting. Could you please add tests for the changed methods? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 89.55% 90.03% +0.47%
==========================================
Files 1 1
Lines 335 331 -4
==========================================
- Hits 300 298 -2
+ Misses 35 33 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tests added. |
|
I have added some more tests. Thank you for contributing. |
AI disclosure: This work was prepared with assistance from OpenAI Codex.
Refresh the retired cache integration so the empty constructor fix can be checked on the current Julia matrix. AI disclosure: This work was prepared with assistance from OpenAI Codex.
The legacy uploader reports authentication failures without failing CI. Use the supported uploader, GitHub OIDC for repository jobs, and tokenless public fork uploads. Fail the coverage step when an upload fails. AI disclosure: This work was prepared with assistance from OpenAI Codex.
quinnj
left a comment
There was a problem hiding this comment.
The approved constructor implementation is retained. I refreshed the current base and repaired the retired cache integration and silent coverage-upload failure. All six checks pass on this exact head, including Julia 1.0, stable, nightly, Windows x86, and both coverage checks; the upload log confirms the report was accepted.
The full local suite passes 327 checks on both Julia 1.6.7 and 1.12.6. An independent check across 20 element/reference-type combinations reproduces the original MethodError on current main and passes 160 checks on the fixed implementation. No further source finding.
AI disclosure: This work was prepared with assistance from OpenAI Codex.
Calling
PooledArray(Int)orPooledArray(Int, UInt64)fails because the empty constructors still use the removedArray(T, 0)API. Construct an emptyArray{T}(undef, 0)instead, preserving the requested element and reference types. The added package tests cover both constructor forms.The branch includes the current base and uses Actions cache v4. Coverage uploads use the supported Codecov action, with tokenless uploads for public fork pull requests and GitHub OIDC for repository jobs. Upload failures now fail CI instead of silently skipping coverage reporting.
Validation:
MethodError.b319fcaad6f2fa50ecfe4f974194eae9f34144e9: Julia 1.0, stable, nightly, Windows x86, and both Codecov coverage checks. The new upload logs confirm successful coverage reporting.git diff --checkpasses.Fixes #85.
Co-authored by Codex
AI disclosure: This work was prepared with assistance from OpenAI Codex.