Skip to content

Fix empty typed constructors - #86

Merged
quinnj merged 8 commits into
JuliaData:mainfrom
kragol:patch-1
Oct 3, 2026
Merged

quinnj merged 8 commits into
JuliaData:mainfrom
kragol:patch-1

Conversation

@kragol

@kragol kragol commented Jul 28, 2023 •

Copy link
Copy Markdown
Contributor

Calling PooledArray(Int) or PooledArray(Int, UInt64) fails because the empty constructors still use the removed Array(T, 0) API. Construct an empty Array{T}(undef, 0) instead, preserving the requested element and reference types. The added package tests cover both constructor forms.

The branch includes the current base and uses Actions cache v4. Coverage uploads use the supported Codecov action, with tokenless uploads for public fork pull requests and GitHub OIDC for repository jobs. Upload failures now fail CI instead of silently skipping coverage reporting.

Validation:

  • Full package suite with bounds checks and four threads: 327 checks passed on Julia 1.6.7 and Julia 1.12.6.
  • Independent reproduction on current main: all 20 combinations of element and reference types raise MethodError.
  • The fixed branch passes 160 checks for empty storage, element/reference types, and adding/removing a value across the same combinations.
  • All six hosted checks pass on b319fcaad6f2fa50ecfe4f974194eae9f34144e9: Julia 1.0, stable, nightly, Windows x86, and both Codecov coverage checks. The new upload logs confirm successful coverage reporting.
  • git diff --check passes.

Fixes #85.

Co-authored by Codex

AI disclosure: This work was prepared with assistance from OpenAI Codex.

@bkamins

bkamins commented Jul 28, 2023

Copy link
Copy Markdown
Member

Thank you for reporting. Could you please add tests for the changed methods?

@codecov

codecov Bot commented Jul 28, 2023 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (25d6928) to head (b319fca).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   89.55%   90.03%   +0.47%     
==========================================
  Files           1        1              
  Lines         335      331       -4     
==========================================
- Hits          300      298       -2     
+ Misses         35       33       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kragol

kragol commented Jul 28, 2023

Copy link
Copy Markdown
Contributor Author

Tests added.

Comment thread test/runtests.jl Outdated
@bkamins

bkamins commented Jul 28, 2023

Copy link
Copy Markdown
Member

I have added some more tests. Thank you for contributing.

Comment thread test/runtests.jl Outdated
Comment thread test/runtests.jl Outdated
quinnj added 2 commits October 3, 2026 15:57
AI disclosure: This work was prepared with assistance from OpenAI Codex.
Refresh the retired cache integration so the empty constructor fix can be checked on the current Julia matrix.

AI disclosure: This work was prepared with assistance from OpenAI Codex.
@quinnj quinnj changed the title fixed bug with empty constructors Fix empty typed constructors Oct 3, 2026
The legacy uploader reports authentication failures without failing CI. Use the supported uploader, GitHub OIDC for repository jobs, and tokenless public fork uploads. Fail the coverage step when an upload fails.

AI disclosure: This work was prepared with assistance from OpenAI Codex.

@quinnj quinnj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approved constructor implementation is retained. I refreshed the current base and repaired the retired cache integration and silent coverage-upload failure. All six checks pass on this exact head, including Julia 1.0, stable, nightly, Windows x86, and both coverage checks; the upload log confirms the report was accepted.

The full local suite passes 327 checks on both Julia 1.6.7 and 1.12.6. An independent check across 20 element/reference-type combinations reproduces the original MethodError on current main and passes 160 checks on the fixed implementation. No further source finding.

AI disclosure: This work was prepared with assistance from OpenAI Codex.

@quinnj
quinnj merged commit 5a86964 into JuliaData:main Oct 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug with empty constructors

3 participants