Skip to content

fix(scanner): Resolve Cargo workspace topology - #88

Merged
JordanCoin merged 1 commit into
JordanCoin:mainfrom
reneleonhardt:fix/rust-cargo-metadata
Aug 1, 2026
Merged

fix(scanner): Resolve Cargo workspace topology#88
JordanCoin merged 1 commit into
JordanCoin:mainfrom
reneleonhardt:fix/rust-cargo-metadata

Conversation

@reneleonhardt

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Derive local Cargo package and target ownership through a shared bounded offline cargo metadata --no-deps scan.
  • Resolve renamed local path dependencies only for eligible normal, build, and dev dependency contexts.
  • Keep the manifest-based resolver when Cargo is unavailable or metadata is invalid, ambiguous, or outside the project.

Type of change

  • Bug fix
  • New feature
  • New language support
  • Documentation
  • Other

Verification

  • go test ./scanner -run '^TestCargo' -count=1
  • go test ./scanner -count=1
  • go test ./...

Additional notes

Depends on the Rust workspace-import foundation merged in #87.

Co-Authored-By: GPT-5.6 Sol codex@openai.com

Co-Authored-By: GPT-5.6 Sol <codex@openai.com>

@JordanCoin JordanCoin left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete change, including Rust workspace/target resolution, dependency-kind eligibility, bounded Cargo metadata fallback behavior, and test coverage. GitHub CI is green and go test ./... passes locally. No blocking findings.

@JordanCoin
JordanCoin merged commit f457cb1 into JordanCoin:main Aug 1, 2026
12 checks passed
@reneleonhardt
reneleonhardt deleted the fix/rust-cargo-metadata branch August 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants