You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Opposite definition for sign of d0 between seeds and tracks causes confusion and issues.
For example, the funciton getPointAtRadius() in org.jlab.rec.cvt.trajectory.Helix is used at several places, with input of radius from a seed or a track. However, the function supposes that definition sign of d0 for seeds and tracks are the same.
With the update, definition for sign of d0 is consistent at the seeding and tracking level.
However, to keep consistent with old definition of d0 for tracks, we still change sign of d0 when writing d0 into track banks, so that we do not change codes in the following reconstruction or in analysis packages. For example, in the EB, d0 is used to set vx and vy.
I did quick check for comparison of tracks between and after the update. Difference is slight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of bugs and tests for fixes are in the slides:
Bug Fixing for CVT Reconstruction.pdf