Repository navigation
Why is return false required? #74
Description
Activity
I don't see a problem with doing it. @JedWatson ?
PRs accepted
Reacted by Naman Goelhttps://github.com/JedWatson/react-tappable/blob/master/src/TappableMixin.js#L68 - however I'll need a test case to understand, as at this stage, I don't understand why that advice is there unless you're somehow handling
onTouchStartyourself (outside of this module).Thanks! For one, capturing all touch events that bubble up to
document, for logging purposes.return falsestops propagation, which is almost never necessary, and kills this use case.I’d prefer it remain open until someone (myself, maintainers, or someone else) can fix it. That the issue is old doesn’t make it any less of an issue :-)
Per https://github.com/JedWatson/react-tappable#native-events, it seems like you're recommending using
return falsefrom an event handler to prevent Tappable from handling the event.However, it's a common best practice (and one my company enforces in its own codebase) to never
return falsefrom an event handler, and to always only explicitly callpreventDefault/stopPropagation/stopImmediatePropagationon the event object.Would it be possible to make Tappable respect
preventDefaulton the event object such thatreturn falseisn't required?