Repository navigation
measure_margins: measure the shipped TRUST_STORE products (L1) - #289
Merged
Merged
Conversation
… CRYPTO_HOT comment The two UCI products ship with TRUST_STORE=1 TRUST_RELEASE=1 (tools/package/_common.sh), and measure_margins measured neither, so the margins it printed for uci-onchip / uci-comb were not the shipped images'. Add uci-onchip-store and uci-comb-store, flag for flag as PACKAGE_VARIANTS builds them; their PRG hashes match the package (da4d607e..., e6750100...). The comb demo (uci-comb-demo-store) was already a profile. The comb cfgs (-onchip.cfg and its cold twin, kept in step for tools/test_cold_bank.py) said CRYPTO_HOT has no room for LIB_X25519_CODE on comb. That holds for the HTTPS_BODY_TO_REU demo only; the shipped comb-store image has CRYPTO_HOT to spare. Say so, and point at the tool instead of a figure. PRG-neutral on every profile. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Review nit: the comment mirrored into cfg/c64-https-uci-onchip.cfg cited the shipped TRUST_STORE product, which that cfg can never link (the Makefile refuses COLD_BANK=0 with TRUST_STORE=1). It now says what the cfg links and that its CRYPTO_HOT question is its own build's. The cold cfg keeps the product-specific text; test_cold_bank.py's CFG_EDITS records the difference (case_cfg_is_the_comb_cfg_plus_the_bank: ok). Comment only: COLD_BANK=0 comb PRG unchanged (9dac6d43...). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layout pass L1.
tools/measure_margins.pynow measures the two shipped UCI products (TRUST_STORE=1 TRUST_RELEASE=1, flag for flag asPACKAGE_VARIANTSbuilds them; hashes match the package). Before this, every margin it printed for uci-onchip / uci-comb was a non-shipped image's. Comment-only cfg fixes. PRG-neutral on every profile.Merge order: independent; merges cleanly with all five sibling PRs.
Commits (messages verbatim; each carries its red-green evidence)
ce3618f measure_margins: add the shipped TRUST_STORE profiles; fix stale comb CRYPTO_HOT comment
The two UCI products ship with TRUST_STORE=1 TRUST_RELEASE=1
(tools/package/_common.sh), and measure_margins measured neither, so the
margins it printed for uci-onchip / uci-comb were not the shipped
images'. Add uci-onchip-store and uci-comb-store, flag for flag as
PACKAGE_VARIANTS builds them; their PRG hashes match the package
(da4d607e..., e6750100...). The comb demo (uci-comb-demo-store) was
already a profile.
The comb cfgs (-onchip.cfg and its cold twin, kept in step for
tools/test_cold_bank.py) said CRYPTO_HOT has no room for
LIB_X25519_CODE on comb. That holds for the HTTPS_BODY_TO_REU demo only;
the shipped comb-store image has CRYPTO_HOT to spare. Say so, and point
at the tool instead of a figure.
PRG-neutral on every profile.
f95a4bb cfg: narrow the ladder comment in the COLD_BANK=0 comb cfg
Review nit: the comment mirrored into cfg/c64-https-uci-onchip.cfg cited
the shipped TRUST_STORE product, which that cfg can never link (the
Makefile refuses COLD_BANK=0 with TRUST_STORE=1). It now says what the cfg
links and that its CRYPTO_HOT question is its own build's. The cold cfg
keeps the product-specific text; test_cold_bank.py's CFG_EDITS records the
difference (case_cfg_is_the_comb_cfg_plus_the_bank: ok).
Comment only: COLD_BANK=0 comb PRG unchanged (9dac6d43...).
🤖 Generated with Claude Code