Skip to content

ci-make improvements - #32

Merged
pflanze merged 3 commits into
mainfrom
cj_ci_make_improvements
Aug 31, 2026
Merged

ci-make improvements#32
pflanze merged 3 commits into
mainfrom
cj_ci_make_improvements

Conversation

@pflanze

@pflanze pflanze commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Some small changes for once.

Allow to easily inspect the outputs especially of "make ci", i.e. when successful runs are not shown on stdout.

This makes it easier to find them all together after a run if needed.
@pflanze
pflanze requested a review from yusufraji August 24, 2026 13:44

@yusufraji yusufraji left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-make: avoid treating input as test commands

Thanks to shellcheck.

I didn't experience any difference before and after the commit. I think I'm missing something.
And What's spellcheck?

Comment thread test/ci-make
@pflanze

pflanze commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

BTW note that ci-make leaks the temp files. It does so on purpose, exactly so that one can go and inspect them afterwards. On GitHub CI the whole context is deleted after a CI run so the files will be gone anyway, and on our local laptops they are just too small to worry about, even if they are only cleaned away on reboot (rebooting once in 6 months when using ci-make 10 times per day on average while producing 20 KB per each run like in this project generates 36 MB of waste, which occupies disk space with a value of (with 200 EUR for a 3.6 TB disk) 0.2 cent). (Why am I even doing this calculation? It used to be that 36 MB was an impossible amount to store on a computer I owned...)

Thanks to shellcheck.

(I thought I had checked that in bash a long time ago and it was no
problem?)
@pflanze
pflanze force-pushed the cj_ci_make_improvements branch from 628281e to 8224809 Compare August 31, 2026 15:03
@pflanze
pflanze merged commit 8224809 into main Aug 31, 2026
1 check passed
@pflanze
pflanze deleted the cj_ci_make_improvements branch August 31, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants