in place divide and floor_divide - #1587
Merged
Merged
Conversation
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
force-pushed
the
divide_in_place
branch
from
October 11, 2023 03:36
fce404c to
f8f1ff7
Compare
vtavana
marked this pull request as ready for review
October 11, 2023 04:48
antonwolfy
reviewed
Oct 11, 2023
vtavana
force-pushed
the
divide_in_place
branch
4 times, most recently
from
October 12, 2023 20:15
8b1656e to
1a58867
Compare
antonwolfy
approved these changes
Oct 12, 2023
antonwolfy
left a comment
antonwolfy
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thank you @vtavana
vtavana
force-pushed
the
divide_in_place
branch
from
October 12, 2023 20:56
1a58867 to
f419e9d
Compare
vtavana
force-pushed
the
divide_in_place
branch
2 times, most recently
from
November 8, 2023 04:44
106537e to
88c113d
Compare
vtavana
force-pushed
the
divide_in_place
branch
from
November 13, 2023 16:52
abc4c4a to
64bf84a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dedicated kernels are implemented in
dpctlfor in-place division and floor division #1431In this PR, this feature is added for
dpnp.divideanddpnp.floor_divide.New tests are written for them.
UPDATE:
With recent updates in
dpctl(#1463), the usage of in-place operator are automatically incorporated indpnp. This PR now only updates the relevant tests.