Skip to content

rework implementation of diag, diagflat, vander, and ptp - #1579

Merged
vtavana merged 7 commits into
masterfrom
diag_vander_ptp_trace
Nov 20, 2023
Merged

rework implementation of diag, diagflat, vander, and ptp#1579
vtavana merged 7 commits into
masterfrom
diag_vander_ptp_trace

Conversation

@vtavana

@vtavana vtavana commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

In this PR, device, usm_type, and sycl_queue keywords are added to dpnp.diag, dpnp.diagflat, dpnp.ptp and dpnp.vander.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 6, 2023
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch 2 times, most recently from c450aae to edaca90 Compare October 7, 2023 04:20
@vtavana
vtavana marked this pull request as ready for review October 7, 2023 14:40
npolina4
npolina4 reviewed Oct 9, 2023
View reviewed changes
Comment thread dpnp/dpnp_array.py Outdated
antonwolfy
antonwolfy reviewed Oct 10, 2023
View reviewed changes
Comment thread dpnp/dpnp_array.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread tests/skipped_tests_gpu.tbl
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
@antonwolfy

antonwolfy commented Oct 22, 2023

Copy link
Copy Markdown
Contributor

please merge the master branch into PR and resolve the conflicts

@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch 2 times, most recently from e0b9f89 to 13f98c9 Compare October 22, 2023 16:51
@vtavana
vtavana changed the base branch from master to max_min October 22, 2023 16:51
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 13f98c9 to 4574364 Compare October 22, 2023 17:01
@github-actions

github-actions Bot commented Oct 22, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 4574364 to b14a157 Compare October 23, 2023 03:31
antonwolfy
antonwolfy reviewed Oct 25, 2023
View reviewed changes
Comment thread dpnp/dpnp_iface_statistics.py Outdated
Comment thread dpnp/dpnp_iface_statistics.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread dpnp/dpnp_iface_arraycreation.py Outdated
Comment thread tests/third_party/cupy/core_tests/test_ndarray_reduction.py
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from b14a157 to 4285f71 Compare October 27, 2023 16:45
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 4285f71 to 265b286 Compare October 30, 2023 17:08
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 265b286 to 1e50360 Compare October 31, 2023 18:15
Base automatically changed from max_min to master November 8, 2023 04:38
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 1e50360 to bd6fcb0 Compare November 8, 2023 17:46
@vtavana
vtavana requested a review from npolina4 November 8, 2023 17:59
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 758532b to 93b6b10 Compare November 14, 2023 14:27
@vtavana
vtavana force-pushed the diag_vander_ptp_trace branch from 93b6b10 to 34a1407 Compare November 16, 2023 18:35
antonwolfy
antonwolfy approved these changes Nov 20, 2023
View reviewed changes

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana !

@vtavana
vtavana merged commit 5bcf910 into master Nov 20, 2023
@vtavana
vtavana deleted the diag_vander_ptp_trace branch November 20, 2023 20:51
@antonwolfy antonwolfy mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes
@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner
+1 more reviewer
@npolina4 npolina4 npolina4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vtavana @antonwolfy @npolina4