Skip to content

Implemented dpnp.hstack() and dpnp.atleast_1d() functions. - #1544

Merged
antonwolfy merged 10 commits into
masterfrom
implement_hstack
Sep 6, 2023
Merged

Implemented dpnp.hstack() and dpnp.atleast_1d() functions.#1544
antonwolfy merged 10 commits into
masterfrom
implement_hstack

Conversation

@npolina4

Copy link
Copy Markdown
Contributor

Implemented dpnp.hstack() and dpnp.atleast_1d() functions.
Added tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions

github-actions Bot commented Aug 28, 2023

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Comment thread dpnp/dpnp_iface_manipulation.py
Comment thread dpnp/dpnp_iface_manipulation.py Outdated
Comment thread dpnp/dpnp_iface_manipulation.py Outdated
Comment thread dpnp/dpnp_iface_manipulation.py
Comment thread tests/test_arraymanipulation.py Outdated
Comment thread tests/test_arraymanipulation.py
Comment thread dpnp/dpnp_iface_manipulation.py Outdated
Comment thread dpnp/dpnp_iface_manipulation.py Outdated
Comment thread tests/test_arraymanipulation.py
Comment thread tests/test_arraymanipulation.py Outdated
Comment thread tests/test_arraymanipulation.py Outdated
Comment thread tests/test_arraymanipulation.py Outdated

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the coverage of dpnp/dpnp_iface_manipulation.py is decreased by 1.18 %

Comment thread dpnp/dpnp_iface_manipulation.py
Comment thread dpnp/dpnp_iface_manipulation.py Outdated
Comment thread dpnp/dpnp_iface_manipulation.py
Comment thread dpnp/dpnp_iface_manipulation.py

@antonwolfy antonwolfy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @npolina4

@antonwolfy
antonwolfy merged commit 80eb738 into master Sep 6, 2023
@antonwolfy
antonwolfy deleted the implement_hstack branch September 6, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants