use_dpctl_round_func_in_dpnp - #1520
Merged
Merged
Conversation
vtavana
changed the base branch from
use_dpctl_rounding_funcs
to
use_dpctl_conj_in_dpnp
August 11, 2023 22:51
vtavana
force-pushed
the
use_dpctl_rounding_funcs
branch
from
August 11, 2023 23:52
677c5e7 to
342b3a4
Compare
vtavana
changed the title
vtavana
force-pushed
the
use_dpctl_rounding_funcs
branch
2 times, most recently
from
August 14, 2023 17:37
bd6ac1e to
46d16a5
Compare
vtavana
force-pushed
the
use_dpctl_round_func
branch
from
August 14, 2023 17:50
16cc19d to
266871d
Compare
vtavana
force-pushed
the
use_dpctl_rounding_funcs
branch
from
August 14, 2023 18:16
46d16a5 to
f6b87a6
Compare
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
force-pushed
the
use_dpctl_round_func
branch
from
August 14, 2023 21:10
266871d to
096ad57
Compare
vtavana
force-pushed
the
use_dpctl_rounding_funcs
branch
from
August 16, 2023 14:57
f6b87a6 to
07e5f86
Compare
vtavana
force-pushed
the
use_dpctl_round_func
branch
3 times, most recently
from
August 16, 2023 17:57
3984319 to
cab701c
Compare
vtavana
force-pushed
the
use_dpctl_rounding_funcs
branch
3 times, most recently
from
August 18, 2023 12:53
836ec09 to
e0bf731
Compare
vtavana
force-pushed
the
use_dpctl_round_func
branch
8 times, most recently
from
August 22, 2023 22:40
8c37fec to
0fd2b2c
Compare
vtavana
force-pushed
the
use_dpctl_round_func
branch
from
August 22, 2023 23:03
0fd2b2c to
eeae83a
Compare
vtavana
marked this pull request as ready for review
August 22, 2023 23:05
vtavana
force-pushed
the
use_dpctl_round_func
branch
from
August 23, 2023 03:45
eeae83a to
67068d4
Compare
antonwolfy
reviewed
Aug 23, 2023
vtavana
force-pushed
the
use_dpctl_round_func
branch
2 times, most recently
from
August 23, 2023 19:58
e17db34 to
ad67495
Compare
antonwolfy
approved these changes
Aug 24, 2023
antonwolfy
left a comment
antonwolfy
left a comment
Contributor
There was a problem hiding this comment.
Great! Thank you @vtavana
antonwolfy
reviewed
Aug 24, 2023
vtavana
force-pushed
the
use_dpctl_round_func
branch
from
August 24, 2023 12:53
ad67495 to
004ac9c
Compare
vtavana
force-pushed
the
use_dpctl_round_func
branch
from
August 24, 2023 15:33
2814d19 to
139d194
Compare
This was referenced Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR changes the implementation of
dpnp.roundand its aliasdpnp.around. These functions now invokeoneapi::mkl::vm::rintfrom pybind11 extension of OneMKL VM if possible or usesdpctl.tensor.roundimplementation if not.