Repository navigation
fix(runtime): address #506 inference review feedback - #592
pengcheng888 merged 1 commit into
Conversation
pengcheng888
left a comment
There was a problem hiding this comment.
一、已解决的一些问题:
(1) csrc/config/config_factory.cpp中对模型的枚举已经删除。
(2) 代码中看起来有了CompressedTensors,AWQ,GPTQ,MXFP4量化代码。也有cache int8量化。
二、其他改动:
(1) 其他可有可无的改动。例如移除中文注释,看起来等价的代码重新组织等。
三、疑问:
(1) csrc/infinicore/src/pybind11/ops/中有多个算子接口文件的移除,这是为啥?
四、仍有的问题:
(1) csrc/engine/compiler/paged_compiler.cpp/static_batching_compiler.cpp ,有挺多改动,未细看,建议恢复。
(2) kv cache的两种形式的shape排布,还没修改回来。
(3) 三个attn计算后端的算子仍没有完全对上。
仍存在的问题会在开发分支上提pr处理。
1d06427
into
refactor/adopt-modern-infini-stack
|
补充说明这条总评里的接口删除问题:#592 删除的是 5 个未注册且无效的 Python binding header:
compiler 改动中删除的是固定 Baichuan prefill、模型名专用 short-decode 和 static 借用 paged graph,保留通用 decode graph 与输入/生命周期保护。attention 后端后续以已合入的 #593 为准;#594 只修正 CLI/benchmark 仍默认选择已移除后端的入口遗漏,并恢复 后续修正及验证:#594 |
Summary
Review fixes for #506, based on
f21b8f9c. This PR targetsrefactor/adopt-modern-infini-stack.Memory/LRU ownership; keep active operator caches stable during device-vector growth.addrparameters, stale dtype references and invalid unregistered bindings), restore T-Head device plumbing, preflight linked providers, add Moore stack-builder support, and avoid direct Linux Python-extension linkage tolibpython.test/native.Motivation
Addresses the review threads on #506 and the associated review register. The reported failures include double-free/use-after-free risks, constructor-unwind crashes, a trace data race, incorrect attention metadata and undeclared deployment dependencies.
Configuration parsing is distinct from provider availability: missing quantized execution paths and dense fused MoE still report unsupported execution. No new smoke cases were added.
Type of Change
fixbuildTest Results of Involved Models on Supported Platforms (Please attach screenshots)
Validated on NVIDIA A100, Python 3.12, in a fresh InfiniLM build directory against the existing matched stack (InfiniRT
0cdbb169, InfiniOpsf890afb4, InfiniCCLe8ccc0cb). Results below are from command logs, not screenshots.infinicore_runtime,_infinicore,_infinilm, wheel buildlibpythondependencyAll four inference variants generated matching 16-token greedy response text for the same prompt. This is a short inference regression, not an accuracy or throughput benchmark. Other accelerator hardware, Python 3.13 and multi-stage PP were not exercised in this revision.
The image's standalone Torch import fails with an empty
LD_LIBRARY_PATHbecause of its HPCX/UCXucs_config_doc_nopmismatch. The successful source-external wheel import used only the image's HPCX directories, with no Python-library path. CUDA's ASan virtual-address conflict requiredASAN_OPTIONS=protect_shadow_gap=0; production behavior is unchanged.Benchmark / Performance Impact
No throughput improvement claim. Free-list removal changes from scanning/erase to indexed swap/pop. Static graph emulation, fixed Baichuan prefill and model-name-specific short-decode acceleration are removed; affected requests use generic decode graphs or eager execution.
Notes for Reviewers
CI / ChatOps
Local and remote validation is recorded above. NVIDIA CI was dispatched on this branch with InfiniCore
main(26f7382d, the merged component manifest). Its format and matrix-generation jobs passed; the NVIDIA build/package job is queued. PR format and Ruff checks also passed. CI status is separate from the completed NVIDIA runtime evidence.Checklist