Repository navigation
fix rope op to adapt with ascend - #1217
Merged
Merged
Conversation
wooway777
approved these changes
Jun 9, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR内容:修改rope算子在昇腾ascend上对BF16数据格式和GPT_NEOX方法进行适配


修改内容:增加InfiniCore\src\infiniop\ops\rope\ascend\rope_ascend.h中对rope_kernel_neox_launch的声明;修改InfiniCore\src\infiniop\ops\rope\ascend\rope_ascend.cc,增加对GPT_NEOX方法的路由;修改InfiniCore\src\infiniop\ops\rope\ascend\rope_ascend_kernel.cpp,增加GPT_NEOX的实现方法,并且新增BF16实现逻辑,将BF16 cast成FP16,计算完成后再cast成BF16;取消InfiniCore/test/infiniop/rope.py对于昇腾的特殊性注释。
现状:infiniop算子测试全部通过
测试样例:
测试结果: