Skip to content

Added support for alembic bool data attributes. #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hradec wants to merge 1 commit into from
Closed

Added support for alembic bool data attributes. #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions contrib/IECoreAlembic/include/IECoreAlembic/IGeomParamTraits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ IECOREALEMBIC_SPECIALISEGEOMPARAMTRAITS( Alembic::AbcGeom::IN2dGeomParam, IECore
IECOREALEMBIC_SPECIALISEGEOMPARAMTRAITS( Alembic::AbcGeom::IN3fGeomParam, IECore::V3fVectorData, IECore::GeometricData::Normal )
IECOREALEMBIC_SPECIALISEGEOMPARAMTRAITS( Alembic::AbcGeom::IN3dGeomParam, IECore::V3dVectorData, IECore::GeometricData::Normal )

IECOREALEMBIC_SPECIALISEGEOMPARAMTRAITS( Alembic::AbcGeom::IBoolGeomParam, IECore::IntVectorData, IECore::GeometricData::Numeric )

@johnhaddon johnhaddon May 18, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this can't be BoolVectorData?

@hradec hradec May 18, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IECoreRI/PrimitiveVariableList.cpp doesn't like BoolVectorData:

cortex/src/IECoreRI/PrimitiveVariableList.cpp

Line 189 in 6fa38ce

msg( Msg::Warning, "PrimitiveVariableList::type", format( "Variable \"%s\" has unsupported datatype \"%s\"." ) % name % d->typeName() );

So for now, I've chose to just convert it to IntVectorData, to minimize changes.

@johnhaddon johnhaddon May 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I really think we should be using bools for this so that we can round-trip data correctly when we add an Alembic writer, and so that renderers that do support bools directly (Arnold for instance) can be properly supported. Do you think you could either use a DataPromoteOp somewhere in your pipeline on the way into RenderMan, or sit on this as a local change until we add a replacement RenderMan backend (it's due an overhaul since Gaffer added a new renderer API more suited to threading and IPR)?


} // namespace IECoreAlembic

#endif // IECOREALEMBIC_IGEOMPARAMTRAITS_H
5 changes: 5 additions & 0 deletions contrib/IECoreAlembic/src/IECoreAlembic/FromAlembicGeomBaseConverter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ void FromAlembicGeomBaseConverter::convertArbGeomParams( Alembic::Abc::ICompound
IM44fGeomParam p( params, header.getName() );
convertGeomParam( p, sampleSelector, primitive );
}
else if( IBoolGeomParam::matches( header ) )
{
IBoolGeomParam p( params, header.getName() );
convertGeomParam( p, sampleSelector, primitive );
}
else
{
msg( Msg::Warning, "FromAlembicGeomBaseConverter::convertArbGeomParams", boost::format( "Param \"%s\" has unsupported type" ) % header.getName() );
Expand Down