Replace Python SDLC validator with strict shell gate - #89
Merged
Merged
Conversation
- scripts/sdlc-checks.sh enforces per-stage approval order and approval fields (Status/Approved-by/Approved-date); legacy bundles without Status headers are grandfathered - templates gain strict status headers; docs and CI (SDLC Gate) rewired - removes scripts/sdlc.py, scripts/sdlc_policy.py, scripts/tests/test_sdlc.py, and all per-bundle state.json (change 2026-08-31-shell-sdlc-gate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the conflict between the parallel SDLC implementations by converging on main's process documents but replacing the Python toolchain:
scripts/sdlc-checks.sh(pure bash): enforces per-stage approval — no stageapprovedbefore the previous one;approvedrequiresApproved-by/Approved-date; malformed statuses fail closed. Wired intoci-basic-checks.shand theSDLC GateCI job.**Status:**header (templates updated); per-bundlestate.jsonremoved as a second source of truth.scripts/sdlc.py,scripts/sdlc_policy.py,scripts/tests/test_sdlc.pyand allstate.jsonfiles.docs/sdlc/README.md, README.md, README_zh.md updated to the shell gate and the strict per-stage approval contract.Verification
bash scripts/sdlc-checks.sh— passbash scripts/ci-basic-checks.sh— passswift testnot run locally: mlx-swift Metal compilation fails under the local CommandLineTools SDK (pre-existing environment issue, unrelated to these docs/script changes); CI runsswift teston macos-26.2026-08-31-shell-sdlc-gate.Historical bundles keep their original evidence text (including past
sdlc.pyruns) — records of what actually happened are not rewritten.