Fix release version inputs and nightly tag validation - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes the release-input failure in nightly run 36334044094. Nightly now supplies
version=0.0.47andtag=v0.0.47; the manual tag entry point also passes its resolved numeric version. New nightly tags use the existing main-tip validation before creation instead of requiring the tag to exist first.SDLC bundle and risk
Verification
See verification evidence.
bash scripts/sdlc-checks.shbash scripts/ci-basic-checks.shswift test: 793 XCTest cases, 18 conditional skips, zero failures; one Swift Testing case passed.bash scripts/build-app.sh --app-only --sign=-: app build and artifact verification passed.Residual risk and rollback
Fixtures intercept push and do not exercise production signing, notarization, GitHub expression evaluation, or a concurrent remote push race. Existing production, signing, and immutable-asset controls are unchanged. Remote CI passed for head
490b075; GitHub reports no merge conflicts. Revert the scoped workflow/test changes if needed; preserve existing tags and published assets.Reviewer focus
Check both callers' step-to-job-to-input version wiring and the
require_ancestor && !create_tagcondition. The nightly create path retains main-tip equality, existing-tag refusal, and non-force push.