fix: prevent unsolicited text insertion from silent recordings - #112
Merged
Merged
Conversation
IchenDEV
marked this pull request as ready for review
September 24, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident and root cause
Four retained menu-bar sessions contain the long ordered
Terms: ...list already in Qwen ASRrawText. The incident-era Qwen path passed that vocabulary asgenerate(context:); formatting changed only its presentation. The original audio and exact runtime prompt were not retained, so the sound that crossed the RMS gate is unknown.Three separate older sessions contain raw
嗯。and processedDo anything. An active auto-learned dictionary rule made that substitution before formatting. Its original source edits were pruned; their intent is unknown.Revised fix
Local evidence
bash scripts/sdlc-checks.shandbash scripts/ci-basic-checks.shpassed.swift test --scratch-path /tmp/utter-silent-insertion-build: 793 XCTest cases, 18 skipped, zero failures; one Swift Testing case passed. Focused Qwen retry and dictionary tests also passed after that run.bash scripts/build-app.sh --app-only --sign=-passed release-style assembly, Metal bundling, and artifact verification. The ad-hoc signature is for local verification.Remaining gates
This PR remains draft. Real computer-microphone/window QA awaits a clean run without the two other Utter instances currently active. Independent high-risk verification, PR approval, trusted signing, and protected production approval remain separate. No release is authorized by this PR.
Current intent, spec, approved plan, draft verification, and rollback notes:
docs/sdlc/changes/2026-09-23-silent-input-insertion/.