Route matricize through an ismatricizeview trait - #229
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
==========================================
- Coverage 80.09% 74.78% -5.32%
==========================================
Files 28 27 -1
Lines 1050 1047 -3
==========================================
- Hits 841 783 -58
- Misses 209 264 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mtfishman
enabled auto-merge (squash)
September 10, 2026 22:46
mtfishman
added a commit
to ITensor/GradedArrays.jl
that referenced
this pull request
Sep 11, 2026
The graded apply path spent most of its time recomputing sector structure on every call. Now axes, matrices, and contraction outputs carry it. Gate sweeps run 2 to 3 times faster and match TensorKit. Builds on ITensor/TensorAlgebra.jl#229. --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matricization now declares its memory behavior: an
ismatricizeviewtrait says which splits share storage,matricizeviewandmatricizecopyimplement the two cases, andmatricizeroutes on the trait. Factorizations use the declarations to make exactly one input copy, replacing runtime aliasing inference, and contracting into a swapped dense destination got 4 to 5 times faster.