Difficulties extending this package #25

Activity

1. otter606 commented on Feb 28, 2023

   

   otter606

   on Feb 28, 2023 via email

   Contributor

   More actions

   Hi Gaby Sure, feel free to submit a pr with the changes you'd like to see. These methods could be made extensible, there just wasn't a use case for this before. Best wishes Richard

   …

   On Tue, 28 Feb 2023, 12:59 pm Gaby, ***@***.***> wrote: Is there a particular reason why a lot of methods are private rather than simply protected or even public? For example in this file : https://github.com/IQSS/dataverse-client-java/blob/44e37e12d015105afef26df63db4949b538ce2b4/src/main/java/com/researchspace/dataverse/entities/facade/DatasetBuilder.java For context I'm using this client to interact with an implementation of the dataverse project. The issue is that there are some differencies between the basic dataverse native API and this implementation. There are some aditional optional or mandatory fields. For this reason I wanted to extend a few classes to add these. But this has proven to be quite difficult. — Reply to this email directly, view it on GitHub <#25>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIDVHISJBNLFZ2BURHEQSLWZXZDRANCNFSM6AAAAAAVKWEFIY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
2. Gabriel-Besombes commented on Mar 3, 2023

   

   Gabriel-Besombes

   on Mar 3, 2023

   Author

   More actions

   Hi,
   Thanks for you quick answer!
   I have forked the project and am currently working on these changes.
   It might take a few weeks before I'm sure I have changed all I need.
   I might also submit an other pr for an issue I have encountered with the "metadataLanguage" field on Dataverses with multiple languages.

   🚀React with 🚀1Reacted by Aleix Mariné-Tena