Skip to content

xmlToJson Issue #11

Description

@abmusse

Original report by Danny Roessner (Bitbucket: droessner, GitHub: droessner).


There is an issue parsing xml output from an sql query using xmlToJson in certain cases.

For example, my query raw response is:

#!xml

<?xml version='1.0'?><myscript><sql>
<query error='fast' conn='conn1' stmt='stmt1'>
<success><![CDATA[+++ success *query here*]]></success>
</query>
<fetch block='all' desc='on' stmt='stmt1'>
<row><data desc='SPCDEC'></data><data desc='SPCCNT'>0</data></row>
<row><data desc='SPCDEC'></data><data desc='SPCCNT'>0</data></row>
<row><data desc='SPCDEC'></data><data desc='SPCCNT'>0</data></row>
<row><data desc='SPCDEC'></data><data desc='SPCCNT'>0</data></row>
<success>+++ success stmt1</success>
</fetch>
</sql>
</myscript>

xmlToJson output:

#!json

[ [ { desc: 'SPCDEC', value: '</data><data desc=\'SPCCNT\'>0' } ],
  [ { desc: 'SPCDEC', value: '</data><data desc=\'SPCCNT\'>0' } ],
  [ { desc: 'SPCDEC', value: '</data><data desc=\'SPCCNT\'>0' } ],
  [ { desc: 'SPCDEC', value: '</data><data desc=\'SPCCNT\'>0' } ] ]

It looks like there is a bug in the sql row regex.

Suggesting changing lines 45-46 in itoolkit.js to:

#!javascript

  var sqlRowG = /<data desc='[\s\S]+?'>[\s\S]*?<\/data>/g;
  var sqlRow = /<data desc='([\s\S]+?)'>([\s\S]*?)<\/data>/;

This fixed the issue for my case.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions