4.X: fix bitfield off-by-one encoding - #108
yuzawa-san wants to merge 2 commits into
Conversation
PR 108 — Fixed Bitfield
Main point: PR 108 is spec-correct on bit indexing; the remaining issue is an off-by-one storage bug that prevents the highest valid ID from being set. Specification for reference |
|
@Tejasshack i believe i have applied the desired fixes in my most recent commits. i actually dropped support for IntegerSet with adjustment of 0 (it is now always 1) and the GppModelTest.consistencyTest does the range 1...24 in one of its cases successfully. |
|
@yuzawa-san I’ve reviewed the changes. Thanks for adding the fixes. This looks good to me. |
this addresses the feedback done in #83 (comment)
from one of the tcf specs: