Repository navigation
fix: a refused truncation-retry batch records and reports its reason - #389
Merged
Merged
Conversation
A retry submit that failed was swallowed in a bare catch and the retry entry had no error field, so the run reported the pass as failed with no diagnostic. The refusal is recorded per model on the entry, explained like submit's refusals, carried on the collect result, and printed in the report. Closes #370 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #370. Verified on
main: the retry submit loop'scatch {}is bare, a{ error }return is dropped, andBroadsideRetryEntryhas noerrorfield — the new test (a provider refusing the retry with the job-queue message) findsrun.retry.status === "failed"with nothing else onmain.{ error }return and a thrown submit) are collected per model, explained throughexplainBatchError, recorded asrun.retry.error, carried asretryErroron the collect result, and printed:↻ The truncation retry could not be submitted — <model>: <reason>. The truncated results stand as collected.Test plan
tests/broadside-post-pass-verdicts.test.mjs: a fetcher refuses the retry post withjob-submission-count … quota: 16; the entry, the result, and the report carry the explained reason; the truncated count still reports. Fails onmain.npm run build+npm test— 937 pass.🤖 Generated with Claude Code