Repository navigation
fix: a __proto__ key in a YAML sequence item is an entry, not the item's prototype - #384
Merged
Merged
Conversation
…m's prototype The mapping parser guards __proto__ through defineProperty; the sequence-item path plain-assigned the first key and the nested-mapping merge, so a "- __proto__:" block set the item's prototype and vanished from its own keys. Both sites now use the same guard. Closes #365 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #365. Verified on
main:core/yaml.tsparseSequenceassignsitem[key] = …(the item's first key, twice) anditem[nestedKey] = nestedValue(the nested-mapping merge) with plain assignment whileparseMappingusesObject.definePropertyfor exactly this key; the new test fails onmain—__proto__is not an own key of the item and the item inheritspolluted.assignItemthat usesdefinePropertywith the same descriptor the mapping parser uses.Test plan
tests/yaml.test.mjs:__proto__as the item's first key and as a nested key are own entries; nothing is inherited; the prototype isObject.prototype.npm run build+npm test— 932 pass.🤖 Generated with Claude Code