Repository navigation
fix: codecarto_publish reads the spec_path it checked - #383
Merged
Merged
Conversation
readSpecArg checked the canonical path and read the original string; a symlink swap between the two could re-point the read outside the allowed roots. The read goes through the canonical path. Closes #362 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #362. Verified on
main:readSpecArgcomputesresolvedSpecPathfor the containment check and then callsreadFile(args.spec_path). One line: the read now usesresolvedSpecPath, so what was checked is what is read. The swap window itself is a timing property no test can pin deterministically; the fix does not depend on it.Test plan
tests/publish-path-containment.test.mjs: a symlink inside the root reads its target through the resolved path; the source is pinned to readresolvedSpecPath.npm run build+npm test— 931 pass.🤖 Generated with Claude Code