Repository navigation
Avoid trust errors for cask conflicts - #23027
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses trust enforcement failures when a cask’s conflicts_with references other casks from third-party taps, ensuring the user doesn’t need to trust uninstalled conflict candidates while still detecting real conflicts.
Changes:
- Prefer installed cask metadata when resolving conflicting casks to avoid loading tap casks unnecessarily.
- Ignore
Homebrew::UntrustedTapErrorwhen evaluating conflicts so untrusted/uninstalled conflict candidates don’t block installs. - Add a regression spec covering the untrusted/uninstalled conflicting cask scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Library/Homebrew/cask/installer.rb |
Adjusts conflict resolution to prefer installed caskfiles and to ignore untrusted/unavailable conflict candidates. |
Library/Homebrew/test/cask/dsl_spec.rb |
Adds a test case ensuring untrusted, uninstalled conflicting casks do not raise during conflict checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- `conflicts_with` casks may be uninstalled candidates from third-party taps. - Loading those tap casks forces trust for packages the user did not request. - Use installed metadata only so conflicts fail without evaluating untrusted code.
MikeMcQuaid
force-pushed
the
fix-cask-conflicts-trust
branch
from
July 9, 2026 08:13
936dfcd to
deff1c4
Compare
MikeMcQuaid
enabled auto-merge
July 9, 2026 10:52
p-linnane
approved these changes
Jul 9, 2026
1 of 12 tasks
timothybrush
pushed a commit
to timothybrush/cli-2
that referenced
this pull request
Sep 15, 2026
`brew tap entireio/tap` fails outright under Homebrew 6's tap trust: tapping runs a readall audit over every cask in the tap, each load hits the trust check, and the tap is left empty behind `Cannot tap entireio/tap: invalid syntax in tap!`. The README told users to run it first, so the documented install died on step one (entireio#2394). A fully qualified `<tap>/<token>` is exempt from that check, and `brew install` auto-taps without the audit (`Tap#install` defaults to `verify: false`; only `cmd/tap.rb` passes `verify: true`), then persists scoped trust for the one cask it installed. So the whole flow collapses to a single command, with `brew upgrade` still working by short name afterwards. This is what entireio#1427 proposed. It was held back because `conflicts_with` then forced you to trust both casks before either would install; Homebrew fixed that in 6.0.10 (Homebrew/brew#23027) by rescuing UntrustedTapError in `check_conflicts`. The other two mechanisms predate tap trust entirely, so 6.0.10 is the floor. Also add a stable-install job to the nightly smoke workflow. The macOS leg only ever installed the nightly cask, and the old sequence there ran `brew trust` before `brew tap` — the working order — so CI stayed green while the README was broken. A runner starts with no tap and no trust entries, which is the state that reproduces it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 01M2FQ0T9HKP0D66WSXARC39PC
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
conflicts_withcasks may be uninstalled candidates from third-party taps.Fixes #23021
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.5 xhigh with local review and testing.