Skip to content

chore(deps): admit pypdf 6, xxhash 4, datasketch 2 and pytest-randomly 4-5 - #1014

Merged
cemililik merged 10 commits into
developmentfrom
deps/python-ranges
Oct 18, 2026
Merged

cemililik merged 10 commits into
developmentfrom
deps/python-ranges

Conversation

@cemililik

@cemililik cemililik commented Oct 18, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Four Dependabot range bumps (#1003, #1008, #1010, #1011) combined into one pull request so they cost one CI round instead of four (each merge makes the others "behind" and the branch protection requires an up-to-date branch). Dependabot closes its own pull requests when the same change lands. The individual Dependabot commits are merged unchanged.

What each range change admits, and the evidence

Dependency Range Where it is used Evidence
datasketch <2 → <3 ingestion-scale extra (MinHash LSH) CI installs 2.0.0 for the full suite (5868 passed, 22 skipped); the data-audit modules also pass locally on 2.0.0 (283 passed)
pytest-randomly <4 → <6 dev extra CI installs 5.0.0 for the full suite (5868 passed, 22 skipped)
xxhash <4 → <5 ingestion extra (simhash) Not exercised by CI (the extra is not installed there). Locally on 4.0.1 the data-audit modules give the same result as on 3.8: 283 passed, 1 skipped
pypdf <6 → <7 ingestion extra (PDF reading) Not exercised by CI: pypdf is not installed there, so the PDF tests skip (224 passed, 19 skipped). Locally the same modules give 238 passed, 5 skipped on both 5.9.0 and 6.21.1

So for xxhash and pypdf the green CI proves nothing; the local runs above are the evidence.

Not included

#1007 (huggingface_hub <2 → <3) is left open on purpose. CI installs 1.33.0 either way, so the change is untested, and widening the range lets pip install hub 2.x for users once their other dependencies allow it. That is a claim ForgeLM has not checked, and the core stack (huggingface_hub, transformers, torch, TRL, PEFT, accelerate, datasets) is migrated deliberately, not by an automatic bump. I would close it, and add a Dependabot ignore for semver-major bumps of that stack; that is a separate change.

Type

  • Dependency

Testing

  • CI (lint, validate, tests on Python 3.10–3.13) on this branch.
  • Local runs against throwaway installs of datasketch 2.0.0, xxhash 4.0.1 and pypdf 5.9.0 / 6.21.1 as in the table.

Checklist

  • CHANGELOG entry under [Unreleased]

🤖 Generated with Claude Code

Summary by Sourcery

Expand dependency compatibility ranges for ingestion extras and development tooling while retaining the existing huggingface_hub constraint.

Enhancements:

  • Broaden supported version ranges for optional ingestion dependencies and development tooling, admitting pypdf 6, xxhash 4, datasketch 2, and pytest-randomly 4–5.

Documentation:

  • Document the newly admitted dependency major versions and their validation status in the unreleased changelog.

Tests:

  • Validate compatibility with the newer dependency versions through CI and targeted local test runs.

Summary by CodeRabbit

  • Chores
    • Expanded supported version ranges for optional ingestion and scaling packages, plus the development testing package. Minimum supported versions are unchanged.
    • Verified ingestion tests with updated package versions and CI with the newer scaling and testing package versions.
    • Updated the changelog to document these compatibility updates.

dependabot Bot and others added 10 commits October 18, 2026 09:42
Updates the requirements on [datasketch](https://github.com/ekzhu/datasketch) to permit the latest version.
- [Release notes](https://github.com/ekzhu/datasketch/releases)
- [Commits](ekzhu/datasketch@v1.6.0...v2.0.0)

---
updated-dependencies:
- dependency-name: datasketch
  dependency-version: 2.0.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [xxhash](https://github.com/ifduyue/python-xxhash) to permit the latest version.
- [Release notes](https://github.com/ifduyue/python-xxhash/releases)
- [Changelog](https://github.com/ifduyue/python-xxhash/blob/master/CHANGELOG.rst)
- [Commits](ifduyue/python-xxhash@v3.0.0...v4.0.1)

---
updated-dependencies:
- dependency-name: xxhash
  dependency-version: 4.0.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [pytest-randomly](https://github.com/pytest-dev/pytest-randomly) to permit the latest version.
- [Changelog](https://github.com/pytest-dev/pytest-randomly/blob/main/CHANGELOG.rst)
- [Commits](pytest-dev/pytest-randomly@3.15.0...5.0.0)

---
updated-dependencies:
- dependency-name: pytest-randomly
  dependency-version: 5.0.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [pypdf](https://github.com/py-pdf/pypdf) to permit the latest version.
- [Release notes](https://github.com/py-pdf/pypdf/releases)
- [Changelog](https://github.com/py-pdf/pypdf/blob/main/CHANGELOG.md)
- [Commits](py-pdf/pypdf@4.0.0...6.20.1)

---
updated-dependencies:
- dependency-name: pypdf
  dependency-version: 6.20.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@sourcery-ai

sourcery-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Sorry @cemililik, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 9 hours and 53 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

@sourcery-ai

sourcery-ai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This dependency-only PR combines four range bumps, widening optional and dev extras to admit pypdf 6, xxhash 4, datasketch 2, and pytest-randomly 4–5. Review the updated bounds in pyproject.toml and verify that the stated CI and local compatibility evidence supports each dependency, noting that xxhash and pypdf were not exercised by CI and huggingface_hub is intentionally excluded.

File-Level Changes

Change Details Files
Widened version constraints for four optional or development dependencies while preserving their existing lower bounds and extras.
  • Admitted pypdf 6 and xxhash 4 in the ingestion extra.
  • Admitted datasketch 2 in the ingestion-scale extra.
  • Admitted pytest-randomly 4 and 5 in the dev extra.
pyproject.toml
Documented the dependency compatibility changes and validation evidence in the unreleased changelog.
  • Recorded the new major-version ranges and tested versions.
  • Clarified that huggingface_hub remains below 2 because it was not validated.
CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 01e11624-80a5-4bfa-a062-b727e2a54acd
📥 Commits

Reviewing files that changed from the base of the PR and between 86eb1f7 and 76bcbdb.

📒 Files selected for processing: 2
  • CHANGELOG.md
  • pyproject.toml

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

📝 Walkthrough

The ingestion, ingestion-scale, and dev extras accept higher maximum versions for selected dependencies. The changelog records tested versions and keeps the huggingface_hub upper bound below 2.

Changes: Dependency version ranges

Layer / File(s) Summary
Update dependency bounds
pyproject.toml, CHANGELOG.md
The extras raise the upper bounds for pypdf, xxhash, datasketch, and pytest-randomly. The changelog records tested versions and retains the huggingface_hub upper bound below 2.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested reviewers: vortsghost2025

Merge Risk: ⚪ Minimal · up to 76bcb

The dependency ranges now admit the listed newer major versions. No concrete incompatibility or disruption to the supported workflows is established, so no actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the dependency range changes and matches the main pull request objective.
Description check Passed The description provides a detailed summary, dependency-specific changes, testing evidence, scope exclusions, type, and changelog confirmation. It does not reproduce every template heading or checkbox…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides a detailed summary, dependency-specific changes, testing evidence, scope exclusions, type, and changelog confirmation. It does not reproduce every template heading or checkbox, but it contains the required information in an equivalent structure.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@cemililik
cemililik merged commit 10fc5a5 into development Oct 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant