Repository navigation
chore(deps): admit pypdf 6, xxhash 4, datasketch 2 and pytest-randomly 4-5 - #1014
Merged
Merged
Conversation
Updates the requirements on [datasketch](https://github.com/ekzhu/datasketch) to permit the latest version. - [Release notes](https://github.com/ekzhu/datasketch/releases) - [Commits](ekzhu/datasketch@v1.6.0...v2.0.0) --- updated-dependencies: - dependency-name: datasketch dependency-version: 2.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [xxhash](https://github.com/ifduyue/python-xxhash) to permit the latest version. - [Release notes](https://github.com/ifduyue/python-xxhash/releases) - [Changelog](https://github.com/ifduyue/python-xxhash/blob/master/CHANGELOG.rst) - [Commits](ifduyue/python-xxhash@v3.0.0...v4.0.1) --- updated-dependencies: - dependency-name: xxhash dependency-version: 4.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [pytest-randomly](https://github.com/pytest-dev/pytest-randomly) to permit the latest version. - [Changelog](https://github.com/pytest-dev/pytest-randomly/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest-randomly@3.15.0...5.0.0) --- updated-dependencies: - dependency-name: pytest-randomly dependency-version: 5.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [pypdf](https://github.com/py-pdf/pypdf) to permit the latest version. - [Release notes](https://github.com/py-pdf/pypdf/releases) - [Changelog](https://github.com/py-pdf/pypdf/blob/main/CHANGELOG.md) - [Commits](py-pdf/pypdf@4.0.0...6.20.1) --- updated-dependencies: - dependency-name: pypdf dependency-version: 6.20.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Sorry @cemililik, you've used your own review budget of 250,000 diff characters for the last 7 days. You can request another review in 9 hours and 53 minutes by commenting |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis dependency-only PR combines four range bumps, widening optional and dev extras to admit pypdf 6, xxhash 4, datasketch 2, and pytest-randomly 4–5. Review the updated bounds in pyproject.toml and verify that the stated CI and local compatibility evidence supports each dependency, noting that xxhash and pypdf were not exercised by CI and huggingface_hub is intentionally excluded. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four Dependabot range bumps (#1003, #1008, #1010, #1011) combined into one pull request so they cost one CI round instead of four (each merge makes the others "behind" and the branch protection requires an up-to-date branch). Dependabot closes its own pull requests when the same change lands. The individual Dependabot commits are merged unchanged.
What each range change admits, and the evidence
datasketch<2→<3ingestion-scaleextra (MinHash LSH)pytest-randomly<4→<6devextraxxhash<4→<5ingestionextra (simhash)pypdf<6→<7ingestionextra (PDF reading)So for xxhash and pypdf the green CI proves nothing; the local runs above are the evidence.
Not included
#1007 (
huggingface_hub<2→<3) is left open on purpose. CI installs 1.33.0 either way, so the change is untested, and widening the range lets pip install hub 2.x for users once their other dependencies allow it. That is a claim ForgeLM has not checked, and the core stack (huggingface_hub, transformers, torch, TRL, PEFT, accelerate, datasets) is migrated deliberately, not by an automatic bump. I would close it, and add a Dependabotignorefor semver-major bumps of that stack; that is a separate change.Type
Testing
Checklist
[Unreleased]🤖 Generated with Claude Code
Summary by Sourcery
Expand dependency compatibility ranges for ingestion extras and development tooling while retaining the existing huggingface_hub constraint.
Enhancements:
Documentation:
Tests:
Summary by CodeRabbit