Nightly CI failure — 2026-04-26 #8

Activity

1. github-actions

   added

   bugSomething isn't workingSomething isn't working

   nightly-failure

   on Apr 26, 2026
2. cemililik commented on Apr 26, 2026

   

   cemililik

   on Apr 26, 2026

   Collaborator

   More actions

   Resolved on the development branch.

   Root cause: the min-deps matrix run (trl==0.12.0 + torch==2.1.0) fails to lazy-load trl.GRPOTrainer because that pairing is missing torch.distributed.fsdp.FSDPModule. mock.patch("trl.GRPOTrainer") calls getattr before swapping, so the patch itself raises AttributeError before the test body runs.

   Fix: 993d840 — test: skip GRPO reward tests when trl.GRPOTrainer not importable. The test module now probes trl.GRPOTrainer at import time and skips the whole TestGrpoRewardCallable class with a pytest.mark.skipif(not grpo_patchable, ...) when the attribute can't be reached. Any environment with a compatible torch ↔ trl pairing still runs the tests normally.

   Subsequent commits on development further evolved this surface (b3e39f0, 2b0df78) — additive default reward + correctness regex + decimal preservation — and renamed the failing tests; all three keep the same skip gate.

   The fix is on development and not yet merged to main. Once development is pushed and merged, the next nightly run will pass this matrix cell.

   Closing as resolved (post-merge verification will happen via the next nightly schedule).
3. cemililik

   closed this as completedon Apr 26, 2026
4. cemililik

   added a commit that references this issue on Apr 28, 2026

   fix(master-review): webhook SSRF/TLS/mask + perf + standards sync

   ...

   3da2810
5. cemililik

   added 3 commits that reference this issue on May 6, 2026

   feat(wave-5-task-j): tools/check_cli_help_consistency.py — CLI / docs…

   ...

   c7bedc9

   fix(wave-5-pr-34-round3): absorb 26 CodeRabbit OOD/Minor + 24 multi-a…

   ...

   dcbdcf5

   feat(site/wizard): full ForgeLM YAML coverage + accordion UX + per-fi…

   ...

   3db4778