Skip to content

Document mTLS revocation checking when the client certificate's issuer is unavailable - #659

Merged
Ethan-Arrowood merged 3 commits into
mainfrom
kris/2380-issuer-unavailable
Sep 4, 2026
Merged

Document mTLS revocation checking when the client certificate's issuer is unavailable#659
Ethan-Arrowood merged 3 commits into
mainfrom
kris/2380-issuer-unavailable

Conversation

@kriszyp

@kriszyp kriszyp commented Sep 1, 2026

Copy link
Copy Markdown
Member

Documents the new behavior when a client certificate's issuer is unavailable to mTLS revocation checking: Harper resolves it from the configured certificate authorities, and otherwise applies failureMode (rejected under fail-closed, allowed under fail-open) with a warning, instead of silently skipping the check. Adds the requirement that the issuing CA be configured on Harper for revocation checking on resumed TLS sessions and behind chain-forwarding proxies, plus a troubleshooting entry for the new warning.

Companion to HarperFast/harper#2457 (fixes HarperFast/harper#2380). Version badge assumes the fix ships in v5.3.0 (the PR's milestone); adjust if it is backported.

🤖 Generated with Claude Code

kriszyp and others added 2 commits September 1, 2026 16:12
…cate's issuer is unavailable

Harper now resolves the issuer from its configured certificate authorities when the
connection does not carry it (resumed TLS sessions, Node.js 26.8.0/26.8.1), and otherwise
applies failureMode instead of silently skipping the check. Companion to HarperFast/harper#2380.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the certificate verification documentation to explain the behavior when an issuer certificate is unavailable, particularly during resumed TLS sessions or when using specific Node.js versions. It also adds troubleshooting steps for the associated warning. The review feedback suggests placing the <VersionBadge> component on a new line below the heading rather than inline, and breaking down the description of the security fallback behaviors into separate, distinct sentences to improve readability and scannability.

Comment thread reference/security/certificate-verification.md Outdated
Comment thread reference/security/certificate-verification.md Outdated
@github-actions
github-actions Bot temporarily deployed to pr-659 September 1, 2026 23:17 Inactive
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-659

This preview will update automatically when you push new commits.

@github-actions
github-actions Bot temporarily deployed to pr-659 September 1, 2026 23:23 Inactive
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-659

This preview will update automatically when you push new commits.

@kriszyp
kriszyp marked this pull request as ready for review September 2, 2026 23:05
@kriszyp
kriszyp requested a review from a team as a code owner September 2, 2026 23:05
@Ethan-Arrowood
Ethan-Arrowood merged commit 9e6ecf8 into main Sep 4, 2026
10 checks passed
@Ethan-Arrowood
Ethan-Arrowood deleted the kris/2380-issuer-unavailable branch September 4, 2026 18:02
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

🧹 Preview Cleanup

The preview deployment for this PR has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mTLS revocation checking fails open when the issuer certificate is unavailable, which Node 26.8.x makes the normal case

2 participants