Skip to content

testDev #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HardMax71 merged 20 commits into from
Sep 7, 2025
Merged

testDev #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
9e81510
- ui improvements (better logo, styles, meta tags)
Jul 27, 2025
00db7c8
fixes
Jul 27, 2025
8617439
fixes 2 - for CI, took another version of setup-k8s.sh
Jul 27, 2025
29c8a20
JWT_SECRET_KEY fix: added validation, + updated .env + added tests
Jul 28, 2025
0e4cce4
JWT_SECRET_KEY fix 2: naming
Jul 28, 2025
7551313
JWT_SECRET_KEY fix 3: key length
Jul 28, 2025
7c0e36e
JWT_SECRET_KEY fix 4: regex instead of separate function
Jul 28, 2025
d624a52
JWT_SECRET_KEY fix 4: regex instead of separate function
Jul 28, 2025
597e209
JWT_SECRET_KEY fix 5: added key to ci/cd
Jul 28, 2025
8ee6bbd
SEC 1.2: added char limits for script length
Jul 28, 2025
8a343b0
SEC 1.3: rate limits for auth routes
Jul 28, 2025
b2ea506
SEC 1.4: mitigation of (possible) XSS in frontend ( -> added `dompuri…
Jul 28, 2025
95eef81
SEC 1.5: better security policy in nginx.conf
Jul 28, 2025
611e75d
SEC 1.6: mongodb login creds added
Jul 28, 2025
904b452
rewrite: using `kubernetes`' watch
Jul 28, 2025
8d0feed
v2: added kafka instead of polling, more details to add sooner
Aug 13, 2025
33d0114
rewrite: using `kubernetes`' watch
Aug 13, 2025
9897abc
v2.1: no globals/magic/xxattr methods, updated code to use DI correctly
Aug 15, 2025
b89a916
v2.0:
Sep 7, 2025
80e763f
- fix of trivy errors (docker scan)
Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 3 additions & 1 deletion .github/workflows/mypy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.12'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install mypy
pip install -r backend/requirements.txt
pip install -r backend/requirements-dev.txt
- name: Run mypy
env:
SECRET_KEY: ${{ secrets.TEST_SECRET_KEY }}
run: mypy --config-file backend/pyproject.toml backend/
2 changes: 1 addition & 1 deletion .github/workflows/ruff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.12'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.12'
- name: Install dependencies
run: |
python -m pip install --upgrade pip
Expand Down
19 changes: 15 additions & 4 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,14 @@ jobs:
# For the backend service
yq eval '.services.backend.extra_hosts += ["host.docker.internal:host-gateway"]' -i docker-compose.ci.yaml
yq eval '.services.backend.environment += ["TESTING=true"]' -i docker-compose.ci.yaml
yq eval '.services.backend.environment += ["MONGO_ROOT_USER=testroot"]' -i docker-compose.ci.yaml
yq eval '.services.backend.environment += ["MONGO_ROOT_PASSWORD=testpassword"]' -i docker-compose.ci.yaml
# Disable OpenTelemetry SDK during tests to avoid exporter retries
yq eval '.services.backend.environment += ["OTEL_SDK_DISABLED=true"]' -i docker-compose.ci.yaml

# For the mongo service
yq eval '.services.mongo.environment += ["MONGO_ROOT_USER=testroot"]' -i docker-compose.ci.yaml
yq eval '.services.mongo.environment += ["MONGO_ROOT_PASSWORD=testpassword"]' -i docker-compose.ci.yaml

# For the cert-generator service
yq eval '.services.cert-generator.extra_hosts += ["host.docker.internal:host-gateway"]' -i docker-compose.ci.yaml
Expand Down Expand Up @@ -75,15 +83,15 @@ jobs:

- name: Wait for backend to be healthy
run: |
timeout 300 bash -c 'until curl -k https://localhost:443/api/v1/health -o /dev/null; do \
timeout 300 bash -c 'until curl -k https://127.0.0.1:443/api/v1/health -o /dev/null; do \
echo "Retrying backend health check..."; \
sleep 5; \
done'
echo "Backend is healthy!"
Comment on lines +86 to 90

@coderabbitai coderabbitai Bot Sep 7, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Health check should fail on HTTP errors.

Without -f, curl exits 0 on 5xx, masking failures.

-          timeout 300 bash -c 'until curl -k https://127.0.0.1:443/api/v1/health -o /dev/null; do \
+          timeout 300 bash -c 'until curl -fsSk https://127.0.0.1:443/api/v1/health -o /dev/null; do \
             echo "Retrying backend health check..."; \
             sleep 5; \
           done'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
timeout 300 bash -c 'until curl -k https://127.0.0.1:443/api/v1/health -o /dev/null; do \
echo "Retrying backend health check..."; \
sleep 5; \
done'
echo "Backend is healthy!"
timeout 300 bash -c 'until curl -fsSk https://127.0.0.1:443/api/v1/health -o /dev/null; do \
echo "Retrying backend health check..."; \
sleep 5; \
done'
echo "Backend is healthy!"
🤖 Prompt for AI Agents 
.github/workflows/tests.yml around lines 86 to 90: the health-check uses curl
without --fail so HTTP 5xx responses still exit 0 and mask backend failures; fix
by adding curl's --fail (or -f) flag and optionally --show-error/--silent to
preserve useful output, so the loop will only succeed on 2xx responses and the
job will fail on HTTP errors.


- name: Wait for frontend to be ready
run: |
timeout 120 bash -c 'until curl -k https://localhost:5001 -o /dev/null; do \
timeout 120 bash -c 'until curl -k https://127.0.0.1:5001 -o /dev/null; do \
echo "Retrying frontend check..."; \
sleep 5; \
done'
Expand All @@ -100,7 +108,7 @@ jobs:
- name: Set up Python for Tests
uses: actions/setup-python@v4
with:
python-version: '3.9'
python-version: '3.12'

- name: Install Python test dependencies
run: |
Expand All @@ -111,8 +119,11 @@ jobs:
pip3 install -r requirements-dev.txt

- name: Run backend tests with coverage
env:
BACKEND_BASE_URL: https://127.0.0.1:443
run: |
cd backend
echo "Using BACKEND_BASE_URL=$BACKEND_BASE_URL"
python -m pytest tests/integration tests/unit -v --cov=app --cov-report=xml --cov-report=term

- name: Upload coverage to Codecov
Expand Down Expand Up @@ -143,4 +154,4 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: integration-test-logs
path: logs/
path: logs/
Loading
Loading