Skip to content

Expected performance unclear from vignette #2

Description

@t-silvers

From the publication and vignette here, it's unclear what is the expected performance of the model. For instance, in BasicExample.ipynb your model assigns weight to each explanatory variable. In the publication, the top 100 genes are selected for further analysis (how? top betas? What parameters yielded those results?).

Some clearer explanations and examples on how you would recommend tuning parameters and training the model would be helpful to include in this repo. For scientific purposes, it would also help in reproducing results from the publication.

Thanks

Activity

  1. HaohanWang commented on Jun 18, 2019

    @HaohanWang
    Owner

    Hi, we selected the top 100 genes based on the absolute values of betas.

    In our paper, we noticed that tuning the parameters according to the desired number of SNPs is a good strategy.

    This repository only serves as an example for people who are interested to use it, if you want to replicate the results for scientific purpose, I'm happy to share the private repo with all the scripts with you. (I will edit the README to avoid further confusion of others about this point.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions