feat(storage): acquire cross-process lock on database open - #47
Merged
Conversation
- New storage/lock.go: ProcessLock using flock(2) for cross-process safety - storage/sqlite.go: Acquire lock in NewStore(), release in Close() - Integrity check (PRAGMA integrity_check) on open - In-memory DSNs bypass lock - Test: TestProcessLock verifies exclusive access, release, and in-memory bypass
This was referenced Aug 15, 2026
- Route lock release errors properly (no unchecked Close/Flock) - golang.org/x/sys is a direct dependency (direct import), go mod tidy CI triage on PR #47.
…72,6089,6090,6091,6218})
…kFileEx windows) CI builds windows/amd64, where unix.Flock does not exist. lock_unix.go (!windows) uses flock(2); lock_windows.go uses LockFileEx with FAIL_IMMEDIATELY for the same non-blocking exclusive semantics.
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 SQLite hardening (1/5).
ProcessLockusing flock(2) on<db>.locknext to the database fileNewStore(), released inClose()TestProcessLockMerge order: this first, then migrations, pragma/metrics, hnsw, backup.