Repository navigation
Scope Object Explorer colours and show rows affected - #92
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change adds affected-row messages to streamed query results and preserves earlier messages before query errors. It also moves Object Explorer color profiles from the explorer container to individual connection tree rows, with browser coverage for styling and accessibility behavior. ChangesQuery message streaming
Object Explorer profile styling
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant SQLServer
participant QueryExecutor
participant ResponseStream
participant QueryStore
SQLServer->>QueryExecutor: StatementCompleted(recordCount)
QueryExecutor->>ResponseStream: affected-row info message
SQLServer->>QueryExecutor: Query error
QueryExecutor->>ResponseStream: accumulated messages
QueryExecutor-->>ResponseStream: QUERY_ERROR
ResponseStream->>QueryStore: streamed messages
QueryStore->>QueryStore: set execution state to failed
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
This PR updates SSMSx’s Object Explorer theming so connection colour profiles apply per-connection subtree (without tinting the whole explorer shell), and enhances query execution messaging by emitting affected-row messages (0/1/N) while preserving successful messages even when a later statement fails.
Changes:
- Scope Object Explorer profile colours to individual rows/subtrees and preserve styling through hover/selection (including forced-colours selection outline).
- Add affected-row message generation in the sidecar (with tests) and ensure messages are delivered before surfacing SQL errors.
- Extend frontend and smoke tests to cover the new theming and messaging behavior.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/frontend/queryUi.test.tsx | Adds unit coverage for preserving streamed messages before a later query error; updates Object Explorer test expectations for per-row styling. |
| tests/frontend/objectExplorerStyles.test.ts | Adds a Node test that boots a Vite fixture + Playwright to validate computed Object Explorer styling and accessibility behavior. |
| tests/frontend/fixtures/objectExplorerStyles.tsx | Fixture app wiring/stores for the Object Explorer styling test scenario. |
| tests/frontend/fixtures/objectExplorerStyles.html | HTML entrypoint for the Object Explorer styling fixture. |
| src/index.css | Introduces row-scoped Object Explorer profile CSS (background/foreground, hover, selection, forced-colours outline). |
| src/features/explorer/components/TreeNode.tsx | Applies per-row profile styling via CSS variables and a dedicated class; uses passed connection/profile info. |
| src/features/explorer/components/ObjectExplorerTree.tsx | Stops tinting the explorer shell; resolves profile/connection per node and passes down to TreeNode. |
| sidecar/tests/Ssmsx.Core.Tests/Query/QueryExecutorTests.cs | Adds tests for affected-row message formatting (negative/0/1/N). |
| sidecar/src/Ssmsx.Core/Query/QueryExecutor.cs | Emits affected-row messages from StatementCompleted and flushes messages before rethrowing SQL errors. |
| scripts/smoke-sidecar.mjs | Expands smoke coverage for affected-row messaging, ordering with PRINT, NOCOUNT suppression, and error ordering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4dcb34f176
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
@coderabbitai review |
|
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Test plan
npm run test:frontendnpm run builddotnet test sidecar/Ssmsx.Sidecar.slnx --filter "Category!=Integration"npm run smoke:sidecarnode scripts/test-sidecar-contract.mjscargo test --manifest-path src-tauri/Cargo.tomlcargo fmt --manifest-path src-tauri/Cargo.toml --checkcargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warningscargo check --manifest-path src-tauri/Cargo.tomlSummary by CodeRabbit
New Features
Bug Fixes
PRINT,SET NOCOUNT ON, and query errors.Tests