Repository navigation
Remove connection profile marker icons - #87
Conversation
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughColor profile marker components are removed from connection, explorer, query, and combobox interfaces. Query tabs and combobox entries retain profile-based background and foreground styling, while tests now verify direct styles and marker absence. ChangesColor profile UI simplification
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
This PR removes the circular connection-profile marker icon across the frontend UI and instead applies each connection’s background/foreground colours directly to query and results tabs, updating DOM/UI tests to match the marker-free design.
Changes:
- Removed
ColorProfileMarkerand its usage across query, explorer, app header, and profile picker surfaces. - Applied connection profile background/foreground colours directly to query tabs and query-results tabs.
- Updated frontend DOM/UI tests to assert marker removal and verify tab/combobox styling.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/frontend/queryUi.test.tsx | Updates assertions from marker presence to full tab background/foreground styling. |
| tests/frontend/connectionAppearanceDom.test.tsx | Adds styling expectations for the combobox and verifies markers are not rendered. |
| src/shared/components/ColorProfileMarker.tsx | Deletes the marker component implementation. |
| src/shared/components/ColorProfileCombobox.tsx | Removes marker rendering and keeps preview/options as fully styled rows. |
| src/features/query/components/QueryTargetBar.tsx | Removes marker from the query target bar. |
| src/features/query/components/QueryTabBar.tsx | Styles query tabs using profile background/foreground instead of a marker. |
| src/features/query/components/QueryStatusBar.tsx | Removes marker from the query status bar. |
| src/features/query/components/QueryResultsTable.tsx | Styles results/messages tabs using profile background/foreground instead of a marker. |
| src/features/explorer/components/TreeNode.tsx | Removes the server-node marker indicator in the explorer tree. |
| src/app/App.tsx | Removes marker from the active-connection display in the app shell. |
Comments suppressed due to low confidence (1)
src/features/query/components/QueryResultsTable.tsx:518
- Same issue as the results-set tabs: when
profileis provided, the inlinestylesetscolor, sotext-text-secondary hover:text-text-primaryin className won’t have any effect. Conditionally apply those classes only when no profile is present to avoid dead/contradictory styling.
className={`inline-flex items-center px-3 py-1 ${activeTab === "messages" ? "border-b-2 border-accent text-text-primary" : "text-text-secondary hover:text-text-primary"}`}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
tests/frontend/connectionAppearanceDom.test.tsx (1)
211-217: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAssert the option foreground color too.
The new test checks the Blue option’s background but not its text color. Add an assertion for
style.colorso both preserved profile styles are covered.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/frontend/connectionAppearanceDom.test.tsx` around lines 211 - 217, Extend the test around the Blue option in the combobox interaction to also assert its foreground color via style.color. Keep the existing background-color assertion and use the expected preserved Blue profile text color.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/shared/components/ColorProfileCombobox.tsx`:
- Around line 178-180: Update the selected profile rendering in
ColorProfileCombobox so the flex item itself applies the truncation and overflow
behavior, rather than leaving truncate only on the nested inline span. Preserve
the existing “No profiles” fallback and ensure long profile names ellipsize
without overlapping the dropdown arrow.
---
Nitpick comments:
In `@tests/frontend/connectionAppearanceDom.test.tsx`:
- Around line 211-217: Extend the test around the Blue option in the combobox
interaction to also assert its foreground color via style.color. Keep the
existing background-color assertion and use the expected preserved Blue profile
text color.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 20eee15a-b07c-4cd1-a565-ef662f8afdc9
📒 Files selected for processing (10)
src/app/App.tsxsrc/features/explorer/components/TreeNode.tsxsrc/features/query/components/QueryResultsTable.tsxsrc/features/query/components/QueryStatusBar.tsxsrc/features/query/components/QueryTabBar.tsxsrc/features/query/components/QueryTargetBar.tsxsrc/shared/components/ColorProfileCombobox.tsxsrc/shared/components/ColorProfileMarker.tsxtests/frontend/connectionAppearanceDom.test.tsxtests/frontend/queryUi.test.tsx
💤 Files with no reviewable changes (1)
- src/shared/components/ColorProfileMarker.tsx
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
Summary
Test plan
npm run test:frontendnpm run builddotnet test sidecar/Ssmsx.Sidecar.slnx --filter "Category!=Integration"cargo test --manifest-path src-tauri/Cargo.tomlSummary by CodeRabbit
UI Improvements
Tests