Repository navigation
Show aliases only in recent connections - #86
Conversation
📝 WalkthroughWalkthroughChangesConnection list display
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
This PR updates the connection list UI to display only a connection’s effective alias (falling back to serverName when no alias is set) and removes the color/profile marker icon from the list rows, aligning the “recent connections” presentation with the simplified design described in the PR.
Changes:
- Simplified
ConnectionListrow content to render onlygetEffectiveAlias(connection)(no server/database/username line). - Removed the
ColorProfileMarkericon fromConnectionListrows while preserving selected-row foreground/background styling via the resolved color profile. - Added a DOM test asserting alias-only rendering, fallback behavior, and absence of profile markers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/frontend/connectionAppearanceDom.test.tsx | Adds coverage for alias-only display, fallback to server name, selection styling, and ensuring profile marker icons are not rendered. |
| src/features/connection/components/ConnectionList.tsx | Removes the profile marker and secondary details line, leaving only the effective alias while keeping selected-row color styling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
I simplified the recent-connections list so an aliased connection shows only its alias. Connections without an alias still fall back to the server name.
I also removed the circular colour marker that looked like a stop-query control. The selected row still uses the connection's configured foreground and background colours.
Test plan
npm run test:frontendnpm run buildcargo check --manifest-path src-tauri/Cargo.tomlSummary by CodeRabbit