Skip to content

Show aliases only in recent connections - #86

Merged
GordonBeeming merged 1 commit into
mainfrom
gb/compact-connection-list
Jul 27, 2026
Merged

GordonBeeming merged 1 commit into
mainfrom
gb/compact-connection-list

Conversation

@GordonBeeming

@GordonBeeming GordonBeeming commented Jul 27, 2026 •

Copy link
Copy Markdown
Owner

Summary

I simplified the recent-connections list so an aliased connection shows only its alias. Connections without an alias still fall back to the server name.

I also removed the circular colour marker that looked like a stop-query control. The selected row still uses the connection's configured foreground and background colours.

Test plan

  • npm run test:frontend
  • npm run build
  • cargo check --manifest-path src-tauri/Cargo.toml
  • Opened the native SSMSx development bundle and checked aliased, unaliased, and selected connection rows.

Summary by CodeRabbit

  • UI Improvements
    • Simplified connection list entries to show only the effective connection alias or server name.
    • Removed profile markers and additional server, database, and username details from connection entries.
    • Preserved connection selection and interaction behavior.
    • Selected connections continue to display their configured profile colors.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Connection list display

Layer / File(s) Summary
Simplify connection item rendering
src/features/connection/components/ConnectionList.tsx
Connection entries now display only their effective alias and no longer render color profile markers or server identity details.
Validate connection appearance
tests/frontend/connectionAppearanceDom.test.tsx
Tests verify alias-only text, absent profile markers, and selected-connection colors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • GordonBeeming/SSMSx#84: Updates related ConnectionList alias display and ColorProfileMarker rendering tests.

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: recent connections now show aliases only, with related UI simplification.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gb/compact-connection-list

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GordonBeeming

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the connection list UI to display only a connection’s effective alias (falling back to serverName when no alias is set) and removes the color/profile marker icon from the list rows, aligning the “recent connections” presentation with the simplified design described in the PR.

Changes:

  • Simplified ConnectionList row content to render only getEffectiveAlias(connection) (no server/database/username line).
  • Removed the ColorProfileMarker icon from ConnectionList rows while preserving selected-row foreground/background styling via the resolved color profile.
  • Added a DOM test asserting alias-only rendering, fallback behavior, and absence of profile markers.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/frontend/connectionAppearanceDom.test.tsx Adds coverage for alias-only display, fallback to server name, selection styling, and ensuring profile marker icons are not rendered.
src/features/connection/components/ConnectionList.tsx Removes the profile marker and secondary details line, leaving only the effective alias while keeping selected-row color styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@GordonBeeming
GordonBeeming marked this pull request as ready for review July 27, 2026 22:57
@GordonBeeming
GordonBeeming merged commit 9c2600e into main Jul 27, 2026
7 checks passed
@GordonBeeming
GordonBeeming deleted the gb/compact-connection-list branch July 27, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants