Skip to content

Address late review feedback from PR #84 #85

Description

@GordonBeeming

Address late review feedback from PR #84

Three review findings landed after #84 had already merged. They are valid follow-up work, but none is critical enough to bypass the pull-request workflow's three-round cap.

Work

  • Reset a dirty connection appearance draft to Red when its selected custom profile is deleted. The picker already falls back visually, but the draft can currently save the deleted profile ID.
  • Replace aria-pressed on connection-selection buttons with selection semantics that screen readers announce correctly.
  • Index connections by ID for query-tab rendering instead of scanning the full connection list for every tab.

Source

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions