Skip to content

Terraform: More import formats and fix name validation for spanner databases - #587

Closed
emilymye wants to merge 1 commit into
masterfrom
tf_spanner_validation
Closed

Terraform: More import formats and fix name validation for spanner databases#587
emilymye wants to merge 1 commit into
masterfrom
tf_spanner_validation

Conversation

@emilymye

@emilymye emilymye commented Oct 18, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #584.

[all]

[terraform]

  • More import formats for google_spanner_database
  • Allow for underscores in name

[puppet]

[puppet-bigquery]

[puppet-compute]

[puppet-container]

[puppet-dns]

[puppet-logging]

[puppet-pubsub]

[puppet-resourcemanager]

[puppet-sql]

[puppet-storage]

[chef]

[chef-compute]

[chef-container]

[chef-dns]

[chef-logging]

[chef-spanner]

[chef-sql]

[chef-storage]

[ansible]

[inspec]

@emilymye emilymye mentioned this pull request Oct 18, 2018
Closed
@modular-magician

modular-magician commented Oct 18, 2018

Copy link
Copy Markdown
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#2285

@emilymye
emilymye requested a review from chrisst October 19, 2018 01:24
@danawillow

danawillow commented Oct 19, 2018

Copy link
Copy Markdown
Contributor

If you could wait until #502 gets in to merge this, that would be great (so that this can get copied to tpgb)

@emilymye
emilymye force-pushed the tf_spanner_validation branch from ec838bb to 39a9bcd Compare October 19, 2018 20:00
@modular-magician

modular-magician commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 2e8ef00) have been included in your existing downstream PRs.

@emilymye
emilymye force-pushed the tf_spanner_validation branch 3 times, most recently from 2ea5d80 to 0c3d542 Compare October 19, 2018 23:00
@modular-magician

modular-magician commented Oct 19, 2018

Copy link
Copy Markdown
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit f1aee9b) have been included in your existing downstream PRs.

@emilymye
emilymye force-pushed the tf_spanner_validation branch from 8456cbd to bbc6223 Compare October 22, 2018 00:57
@modular-magician

modular-magician commented Oct 22, 2018

Copy link
Copy Markdown
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 7508d53) have been included in your existing downstream PRs.

@emilymye
emilymye force-pushed the tf_spanner_validation branch 2 times, most recently from d90f399 to eb318f6 Compare October 23, 2018 16:45
@chrisst
chrisst force-pushed the tf_spanner_validation branch from eb318f6 to a965c4c Compare October 23, 2018 20:24
@emilymye
emilymye force-pushed the tf_spanner_validation branch from a965c4c to e9c9c3b Compare October 23, 2018 20:48
@emilymye

emilymye commented Oct 23, 2018

Copy link
Copy Markdown
Contributor Author

Killing this and resubmitting because of weird patch issues :(

@emilymye emilymye closed this Oct 23, 2018
@emilymye emilymye mentioned this pull request Oct 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@chrisst chrisst chrisst approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes downstream-generated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@emilymye @modular-magician @danawillow @chrisst @googlebot