mark encryption keys as immutable and sensitive across compute and backupdr resources

[harshulsoni]

compute: mark encryption keys as immutable and sensitive across compute and backupdr resources

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[melinath]

/gcbrun

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 20e5ddc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	3 files changed, 21 insertions(+)
google-beta provider	View Diff	4 files changed, 22 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_restore_workload (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_restore_workload" "primary" {
  compute_instance_restore_properties {
    disks {
      disk_encryption_key {
        raw_key           = # value needed
        rsa_encrypted_key = # value needed
      }
    }
    instance_encryption_key {
      raw_key           = # value needed
      rsa_encrypted_key = # value needed
    }
  }
  disk_restore_properties {
    disk_encryption_key {
      raw_key           = # value needed
      rsa_encrypted_key = # value needed
    }
  }
}

Resource: google_compute_machine_image (33 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_machine_image" "primary" {
  machine_image_encryption_key {
    raw_key = # value needed
  }
}

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1482	1341	105	36

Affected Service Packages

• backupdr
• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 36 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeAutoscaler_autoscalerBasicExample
• TestAccComputeAutoscaler_autoscalerSingleInstanceExample
• TestAccComputeAutoscaler_multicondition
• TestAccComputeAutoscaler_scaleDownControl
• TestAccComputeAutoscaler_scaleInControl
• TestAccComputeAutoscaler_scaleInControlFixed
• TestAccComputeAutoscaler_scalingSchedule
• TestAccComputeAutoscaler_update
• TestAccComputeForwardingRule_forwardingRuleBasicExample
• TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
• TestAccComputeForwardingRule_ip
• TestAccComputeForwardingRule_networkTier
• TestAccComputeForwardingRule_serviceDirectoryRegistrations
• TestAccComputeForwardingRule_update
• TestAccComputeInstanceFromTemplate_DiskForceAttach
• TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
• TestAccComputeRegionAutoscaler_scaleDownControl
• TestAccComputeRegionAutoscaler_scaleInControl
• TestAccComputeRegionAutoscaler_scalingSchedule
• TestAccComputeRegionAutoscaler_update
• TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
• TestAccComputeTargetPool_update
• TestAccComputeTargetPool_withSecurityPolicy
• TestAccDataSourceGoogleComputeInstanceGroupManager
• TestAccDataSourceGoogleComputeRegionInstanceGroupManager
• TestAccDataSourceGoogleForwardingRule
• TestAccDataSourceGoogleForwardingRules
• TestAccInstanceGroupManager_autoHealingPolicies
• TestAccInstanceGroupManager_basic
• TestAccInstanceGroupManager_self_link_unique
• TestAccInstanceGroupManager_stateful
• TestAccInstanceGroupManager_update
• TestAccInstanceGroupManager_waitForStatus
• TestAccRegionInstanceGroupManager_autoHealingPolicies
• TestAccRegionInstanceGroupManager_basic
• TestAccRegionInstanceGroupManager_update

View the build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeAutoscaler_autoscalerBasicExample
✅ Log	✅	TestAccComputeAutoscaler_autoscalerSingleInstanceExample
✅ Log	✅	TestAccComputeAutoscaler_multicondition
✅ Log	✅	TestAccComputeAutoscaler_scaleDownControl
✅ Log	✅	TestAccComputeAutoscaler_scaleInControl
✅ Log	✅	TestAccComputeAutoscaler_scaleInControlFixed
✅ Log	✅	TestAccComputeAutoscaler_scalingSchedule
✅ Log	✅	TestAccComputeAutoscaler_update
✅ Log	✅	TestAccComputeForwardingRule_forwardingRuleBasicExample
✅ Log	✅	TestAccComputeForwardingRule_forwardingRulePscTargetUpdateRecreate
✅ Log	✅	TestAccComputeForwardingRule_networkTier
✅ Log	✅	TestAccComputeForwardingRule_serviceDirectoryRegistrations
✅ Log	✅	TestAccComputeForwardingRule_update
✅ Log	✅	TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample
✅ Log	✅	TestAccComputeRegionAutoscaler_scaleDownControl
✅ Log	✅	TestAccComputeRegionAutoscaler_scaleInControl
✅ Log	✅	TestAccComputeRegionAutoscaler_scalingSchedule
✅ Log	✅	TestAccComputeRegionAutoscaler_update
✅ Log	✅	TestAccComputeTargetPool_update
✅ Log	✅	TestAccComputeTargetPool_withSecurityPolicy
✅ Log	✅	TestAccDataSourceGoogleComputeInstanceGroupManager
✅ Log	✅	TestAccDataSourceGoogleComputeRegionInstanceGroupManager
✅ Log	✅	TestAccDataSourceGoogleForwardingRule
✅ Log	✅	TestAccDataSourceGoogleForwardingRules
✅ Log	✅	TestAccInstanceGroupManager_autoHealingPolicies
✅ Log	✅	TestAccInstanceGroupManager_basic
✅ Log	✅	TestAccInstanceGroupManager_self_link_unique
✅ Log	✅	TestAccInstanceGroupManager_stateful
✅ Log	✅	TestAccInstanceGroupManager_update
✅ Log	✅	TestAccInstanceGroupManager_waitForStatus
✅ Log	✅	TestAccRegionInstanceGroupManager_autoHealingPolicies
✅ Log	✅	TestAccRegionInstanceGroupManager_basic
✅ Log	✅	TestAccRegionInstanceGroupManager_update
❌ Error · Log	-	TestAccComputeForwardingRule_ip
❌ Error · Log	-	TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log	-	TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@harshulsoni, @trodge VCR tests complete for 20e5ddc!

[github-actions]

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @trodge This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.