Skip to content

feat: Added Terraform support for Cloud Bigtable Editions - #17529

Merged
rileykarson merged 2 commits into
GoogleCloudPlatform:mainfrom
NickASC4:editions
May 21, 2026
Merged

rileykarson merged 2 commits into
GoogleCloudPlatform:mainfrom
NickASC4:editions

Conversation

@NickASC4

@NickASC4 NickASC4 commented May 12, 2026 •

Copy link
Copy Markdown
Contributor
bigtable: added `edition` field to `google_bigtable_instance` resource

@github-actions
github-actions Bot requested a review from hao-nan-li May 12, 2026 22:22
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@hao-nan-li, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician

modular-magician commented May 12, 2026 •

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit c09dec6:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 136 insertions(+), 1 deletion(-)
google-beta provider View Diff 5 files changed, 136 insertions(+), 1 deletion(-)

Missing doc report (experimental)

The following resources have fields missing in documents.

  • google_bigtable_instance
    • Expected Document Path: /website/docs/r/bigtable_instance.html.markdown
    • Fields: [edition]

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccBigtableInstance_edition
🔴 TestAccBigtableInstance_editionEnterprisePlus

Analytics

Total Tests Passed Skipped Affected
6424 5752 659 13
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeInstanceFromTemplate_DiskForceAttach
  • TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ❌ Error · Log TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_create
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccComputeInstanceFromTemplate_DiskForceAttach
❌ Error · Log - TestAccComputeSubnetwork_secondaryIpRanges_sendEmpty
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccEphemeralServiceAccountKey_upload
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@NickASC4, @annguy3n, @hao-nan-li VCR tests complete for c09dec6!

@modular-magician
modular-magician requested a review from annguy3n May 12, 2026 22:31
@NickASC4

Copy link
Copy Markdown
Contributor Author

I looked at the logs and don't think any of the failing tests seem to have to do with my PR? Seems like mostly connection issues.

I also manually verified my two new testsTestAccBigtableInstance_edition and TestAccBigtableInstance_editionEnterprisePlus to be passing.

@hao-nan-li
hao-nan-li requested review from a team and rileykarson and removed request for a team and hao-nan-li May 14, 2026 19:42
@hao-nan-li

Copy link
Copy Markdown
Contributor

Reassign as I will be OOO.

@github-actions

Copy link
Copy Markdown

@hao-nan-li This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
github-actions Bot requested a review from rileykarson May 20, 2026 16:28
@modular-magician

modular-magician commented May 20, 2026 •

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 65ba8c7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 6 files changed, 141 insertions(+), 1 deletion(-)
google-beta provider View Diff 6 files changed, 141 insertions(+), 1 deletion(-)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccBigtableInstance_edition
🔴 TestAccBigtableInstance_editionEnterprisePlus

Analytics

Total Tests Passed Skipped Affected
6439 5767 658 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
  • TestAccCloudRunService_cloudRunServiceGpuExample
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccEphemeralServiceAccountKey_create
  • TestAccEphemeralServiceAccountKey_upload
  • TestAccIapWebTypeAppEngineIamMemberGenerated
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccSourceRepoRepositoryIamMemberGenerated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log ✅ TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log ✅ TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_create
✅ Log ❌ Error · Log TestAccEphemeralServiceAccountKey_upload
❌ Error · Log - TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample
❌ Error · Log - TestAccCloudRunService_cloudRunServiceGpuExample
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccIapWebTypeAppEngineIamMemberGenerated
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccSourceRepoRepositoryIamMemberGenerated

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@NickASC4, @rileykarson, @annguy3n VCR tests complete for 65ba8c7!

@rileykarson rileykarson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rileykarson
rileykarson added this pull request to the merge queue May 21, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 2cbf52b May 21, 2026
25 of 26 checks passed
MikolajLuczko pushed a commit to MikolajLuczko/magic-modules that referenced this pull request May 28, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants