Skip to content

tgc: fix diffs for container cluster - #17488

Merged
zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:tgc-container
May 11, 2026
Merged

zli82016 merged 1 commit into
GoogleCloudPlatform:mainfrom
zli82016:tgc-container

Conversation

@zli82016

@zli82016 zli82016 commented May 9, 2026 •

Copy link
Copy Markdown
Member

Two fields min_master_version and node_version caused import diffs, so remove them.

When auto_provisioning_defaults has default value from API, it is not converted.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9437597:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 2 files changed, 1 insertion(+), 1 deletion(-)

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b5370bd:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 2 files changed, 2 insertions(+), 2 deletions(-)

@zli82016
zli82016 marked this pull request as ready for review May 11, 2026 16:28
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5dd1329:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 2 files changed, 9 insertions(+), 6 deletions(-)

@zli82016

Copy link
Copy Markdown
Member Author

/gcbrun

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 5dd1329:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
terraform-google-conversion View Diff 2 files changed, 9 insertions(+), 6 deletions(-)

@zli82016
zli82016 requested a review from hao-nan-li May 11, 2026 22:36
@zli82016
zli82016 added this pull request to the merge queue May 11, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 24e92e5 May 11, 2026
23 checks passed
@zli82016
zli82016 deleted the tgc-container branch May 11, 2026 23:26
pragya644 pushed a commit to pragya644/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
inadenenko pushed a commit to inadenenko/magic-modules that referenced this pull request May 12, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants