Skip to content

Make rules optional in backup plan - #16737

Merged
SirGitsalot merged 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:tf-restore
Mar 18, 2026
Merged

SirGitsalot merged 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:tf-restore

Conversation

@Megha-Bose

Copy link
Copy Markdown
Contributor
backupdr: made backup rules optional in backup plans

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 17, 2026
@github-actions
github-actions Bot requested a review from SirGitsalot March 17, 2026 11:02
@github-actions

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@Megha-Bose Megha-Bose changed the title Tf restore Make rules optional in backup plan Mar 17, 2026
@Megha-Bose
Megha-Bose force-pushed the tf-restore branch 3 times, most recently from 95fe5bd to 9ebe3e2 Compare March 17, 2026 11:07
@modular-magician modular-magician added service/backupdr and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 17, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))
google-beta provider: Diff ( 2 files changed, 32 insertions(+), 32 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 27 insertions(+), 27 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 35
Passed tests: 23
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • backupdr

🟢 All tests passed!

View the build log

@SirGitsalot
SirGitsalot added this pull request to the merge queue Mar 18, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 2e8e11d Mar 18, 2026
26 checks passed
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 18, 2026
carreter pushed a commit to carreter/magic-modules that referenced this pull request Apr 2, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
gitika-yadav pushed a commit to gitika-yadav/magic-modules that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants