fix(opportunities): add fieldValue (preferred) + deprecate field_value in custom-field schemas - #321
Open
MCPVOT wants to merge 1 commit into
Open
fix(opportunities): add fieldValue (preferred) + deprecate field_value in custom-field schemas#321MCPVOT wants to merge 1 commit into
MCPVOT wants to merge 1 commit into
Conversation
…e in custom-field schemas Same fix as PR GoHighLevel#320 (contacts.json): the opportunities spec documented only snake_case field_value in all 3 custom-field input schemas, while the v3 spec uses fieldValue. Add the fieldValue twin (preferred) + deprecate field_value, mirroring the v3 contract exactly. JSON verified clean before/after; 3 schemas upgraded.
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  45 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
🛡️ The following IaC misconfigurations have been detected
| NAME | FILE | ||
|---|---|---|---|
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Template Path With No Corresponding Path Parameter | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Object Without Required Property | ...s/opportunities.json | View in code |
|
Schema Has A Required Property Undefined | ...s/opportunities.json | View in code |
|
Security Requirement Object With Wrong Scopes | ...s/opportunities.json | View in code |
|
Security Requirement Object With Wrong Scopes | ...s/opportunities.json | View in code |
|
Security Requirement Object With Wrong Scopes | ...s/opportunities.json | View in code |
| ... | ... | ... | ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same bug class as PR #320 (contacts.json): the opportunities spec documents only snake_case field_value in all 3 custom-field input schemas (customFieldsInputArraySchema, customFieldsInputObjectSchema, customFieldsInputStringSchema). The v3 spec (apps/v3/opportunities-v3.json) uses fieldValue. Mirror the v3 contract: add fieldValue (preferred, with description) + deprecate field_value. JSON verified clean before/after; exactly 3 schemas upgraded. Diff: 31 insertions, 4 deletions in apps/opportunities.json.