Skip to content

Bidirectional handler↔module dependency in handlers/pipeline.go #63

Description

@intel352

Problem

The handlers package directly imports and holds concrete types from the module package (*module.Pipeline, *module.StepRegistry). This creates a bidirectional dependency and means handlers cannot be tested without instantiating real module types.

Fix Direction

Define PipelineRunner and StepRegistry interfaces in a shared package (e.g. workflow/interfaces or as part of the plugin contract). Have handlers depend on these interfaces; module implements them. This breaks the import cycle and enables proper unit testing of handlers with mocks.

Context

See docs/DEFERRED_ISSUES.md — Architecture section.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

architectureArchitectural design and coupling issues

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions