Skip to content

Plugin exposes concrete handler type via getter (plugins/pipelinesteps/plugin.go) #60

Description

@intel352

Problem

plugins/pipelinesteps/plugin.go retains a *handlers.PipelineWorkflowHandler field and exposes it via a PipelineHandler() getter. cmd/server/main.go then calls this getter and directly sets properties on the handler, bypassing the plugin interface contract.

Fix Direction

Use wiring hooks in the plugin lifecycle to perform setup internally. The caller should never need to reach inside a plugin to configure it. Move the SetStepRegistry call and any other direct property sets into the plugin's own Init() or wiring hook so cmd/server/main.go only calls standard plugin lifecycle methods.

Context

See docs/DEFERRED_ISSUES.md — Architecture section.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    architectureArchitectural design and coupling issues

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions