Skip to content

fix(import): preserve orphaned relation audits - #1311

Draft
dnlrsls wants to merge 1 commit into
Gentleman-Programming:fix/2.1.0-03-doctor-authorityfrom
dnlrsls:fix/2.1.0-04-orphaned-relations
Draft

dnlrsls wants to merge 1 commit into
Gentleman-Programming:fix/2.1.0-03-doctor-authorityfrom
dnlrsls:fix/2.1.0-04-orphaned-relations

Conversation

@dnlrsls

@dnlrsls dnlrsls commented Sep 21, 2026

Copy link
Copy Markdown
Member

🔗 Linked Issue

Closes #1291


🏷️ PR Type

  • type:bug — Bug fix
  • type:feature — New feature
  • type:question — Question requiring tracked work
  • type:docs — Documentation only
  • type:refactor — Code refactoring (no behavior change)
  • type:chore — Maintenance, dependencies, tooling
  • type:breaking-change — Breaking change

📝 Summary

  • Preserve explicitly orphaned relation audit rows during import.
  • Keep live graph integrity fail-loud when a non-orphan endpoint is missing.

📂 Changes

File Change
DOCS.md Updated by the orphaned relation audit slice.
internal/store/store.go Updated by the orphaned relation audit slice.
internal/store/store_test.go Updated by the orphaned relation audit slice.

🧪 Test Plan

  • Focused and full store tests pass locally.
  • Candidate lint reports 0 issues.
  • git diff --check passes.
  • User-facing behavior documentation reviewed.

✅ Contributor Checklist


Chain Context

Field Value
Chain Engram 2.1.0 blocker integration
Position 4 of 13
Base fix/2.1.0-03-doctor-authority @ c40e12ed
Depends on #1310
Follow-up fix/2.1.0-05-cloud-materialization
Review budget 193 / 400 changed lines
Starts at Doctor authority slice
Ends with Orphaned relation audit preservation

Scope

Autonomy

  • CI is expected to pass for this PR branch
  • One deliverable scope
  • Rollback excludes unrelated changes
  • Tests cover this unit

💬 Notes for Reviewers

Draft only. Native RDD lineage review-9f5f335b8afd1821 approved without advisories and was acknowledged. Independent verification noted one stale internal store.go comment as a non-blocking readability follow-up; runtime behavior and user documentation are correct. Merge authorization is not granted.

@dnlrsls dnlrsls added the type:bug Bug fix label Sep 21, 2026
@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant