pygmt.show_versions: Improve the reported GMT version - #4813
Open
yvonnefroehlich wants to merge 3 commits into
Open
pygmt.show_versions: Improve the reported GMT version#4813yvonnefroehlich wants to merge 3 commits into
yvonnefroehlich wants to merge 3 commits into
Conversation
yvonnefroehlich
added
the
maintenance
seisman
reviewed
Aug 10, 2026
| if not hasattr(self, "_info"): | ||
| self._info = { | ||
| "version": self.get_default("API_VERSION"), | ||
| "version": self.get_default("API_BIN_VERSION"), |
Member
There was a problem hiding this comment.
Hmmm. Someone may likely use Session.info("version") to check the current GMT library version, so this looks like a breaking change.
Maybe keep the Session.info() dictionary unchanged, but only change the output only of pygmt.show_versions? I.e., manipulate the dictionary in _get_clib_info().
seisman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
xref: #4812 (comment)
Fixes #4812
Preview:
Guidelines
Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code