Repository navigation
fix(docs): match Helm values, backup Secret namespace and OIDC role mapping to the code - #6
Conversation
…apping to the code
- installation: networkPolicies.kubeletCIDRs is a list and
gameEgress.ports entries are {protocol, port} objects (the chart ranges
over both); the string/integer examples failed to render.
- installation: the Helm OIDC example with groupsClaim/defaultRole/
roleMappings/displayName is v0.3.0+; beta.8's chart only has
enabled/issuer/clientID/clientSecretRef/redirectURL.
- backup-restore-crds: the restic repo Secret must live in the Backup's
namespace; the operator looks it up there.
- sign-in-recovery: beta.8 already maps IdP groups to roles per provider
(Admin Settings -> Authentication); only Helm seeding is v0.3.0.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UshpSigdLccuYZi7oFJX9y
Signed-off-by: Claude <noreply@anthropic.com>
PR Summary by QodoCorrect Helm, backup Secret, and OIDC documentation
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
…llouts beta.8's chart takes only the connection keys; displayName, groupsClaim, defaultRole and roleMappings arrive in v0.3.0. Per-provider group-to-role mapping already works in beta.8 via Admin Settings, so the sign-in callout and effective-role text now say only Helm seeding is new. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UshpSigdLccuYZi7oFJX9y Signed-off-by: Claude <noreply@anthropic.com>
Code Review by Qodo
No findings for this group 1. OIDC mapping remains falsely marked unavailable
|
Summary
Fixes the four findings Qodo raised on ValgulNecron/Gameplane#520, the submodule bump to this site. I checked each one against the Gameplane chart and code.
installation.mdx, network policies example:networkPolicies.kubeletCIDRsis now a YAML list. The chart ranges over it (templates/networkpolicies.yaml), so the old comma-separated string broke rendering.gameEgress.portsentries are now{ protocol: TCP, port: 443 }objects. The chart reads.protocoland.portfrom each entry, so the old bare integers failed.installation.mdx, OIDC example: the snippet is now split by chart version.enabled,issuer,clientID,clientSecretRefandredirectURL. The redirect URL points at the/auth/oidc/callbackpath that beta.8 serves. On beta.8, group mapping is set per provider under Admin Settings → Authentication.displayName,groupsClaim,defaultRoleandroleMappings.backup-restore-crds.mdx:backup_controller.golooks it up inb.Namespaceand fails the Backup if it isn't there.gameplane-system, and its example Secret now setsnamespace: gameplane-games.sign-in-recovery.mdx:api/internal/auth/oidc.goat v0.2.0-beta.8).Verification
astro buildsucceeds (93 pages).🤖 Generated with Claude Code
https://claude.ai/code/session_01UshpSigdLccuYZi7oFJX9y